fix: stop using ServiceNodeExclusion feature gate after it is GA #4466
Conversation
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #4466 +/- ##
========================================
Coverage 72.04% 72.05%
========================================
Files 141 141
Lines 21631 21765 +134
========================================
+ Hits 15584 15682 +98
- Misses 5096 5131 +35
- Partials 951 952 +1
Continue to review full report at Codecov.
|
| @@ -81,7 +82,10 @@ func (cs *ContainerService) setControllerManagerConfig() { | |||
| } | |||
|
|
|||
| // Enables Node Exclusion from Services (toggled on agent nodes by the alpha.service-controller.kubernetes.io/exclude-balancer label). | |||
| addDefaultFeatureGates(o.KubernetesConfig.ControllerManagerConfig, o.OrchestratorVersion, "1.9.0", "ServiceNodeExclusion=true") | |||
| // ServiceNodeExclusion feature gate is GA in 1.19, removed in 1.22 (xref: https://github.com/kubernetes/kubernetes/pull/100776) | |||
| if !common.IsKubernetesVersionGe(o.OrchestratorVersion, "1.19.0") { | |||
There was a problem hiding this comment.
nit: little awkward to read but looks like we don't have a LessThan function
There was a problem hiding this comment.
yeah this is the common pattern for less than
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong, jackfrancis, jsturtevant, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ernest Wong chuwon@microsoft.com
Reason for Change:
Fixes test failure in https://testgrid.k8s.io/sig-windows-master-release#aks-engine-windows-containerd-master
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: