Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: flexvol and csi addons disabled by default #4546

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR changes the default addons installation flow so that the following addons are no longer installed by default:

  • blobfuse flexvolume
  • keyvault flexvolume

The above addons will be disabled by default because they have been deprecated in favor of alternate solutions

  • secrets-csi-driver

The above addon will be disabled by default because it is no longer actively maintained, and the preferred maintenance gesture is to use the official helm chart.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

cc @andyzhangx @aramase

@acs-bot
Copy link

acs-bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Azure Azure deleted a comment from codecov bot Jun 29, 2021
@andyzhangx
Copy link
Contributor

it's ok to disable blobfuse flexvol driver since it's deprecated, user should use blob csi drive instead, thanks.

@jackfrancis
Copy link
Member Author

@andyzhangx thx for confirming! :)

@mboersma mboersma enabled auto-merge (squash) June 30, 2021 17:05
@mboersma mboersma added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Jun 30, 2021
@Azure Azure deleted a comment from codecov bot Jun 30, 2021
Copy link
Collaborator

@Michael-Sinz Michael-Sinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, this is so good to see - I can (eventually) reduce the list of things I have to disable as they were enabled by default.

Only concern would be teams that may depend on this. We will need to make sure that this is called out expressly in the release notes as a "breaking" change and that the user would need to expressly enable these addons if they wanted to continue to use them.

@jackfrancis
Copy link
Member Author

@Michael-Sinz the current release CI allows project maintainers to edit and curate the release notes before merging to the release branch (that merge acts as a gate to actually validate and publish release artifacts). So you'll have a chance to weigh in then to ensure we're doing sufficient communication.

@Michael-Sinz
Copy link
Collaborator

@Michael-Sinz the current release CI allows project maintainers to edit and curate the release notes before merging to the release branch (that merge acts as a gate to actually validate and publish release artifacts). So you'll have a chance to weigh in then to ensure we're doing sufficient communication.

Will have to see how that works out - I hope it gives hints as to what all of the changes were from the prior release.

@jackfrancis jackfrancis removed the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Jun 30, 2021
@mboersma mboersma merged commit 29213a4 into Azure:master Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants