-
Notifications
You must be signed in to change notification settings - Fork 522
feat: flexvol and csi addons disabled by default #4546
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
it's ok to disable blobfuse flexvol driver since it's deprecated, user should use blob csi drive instead, thanks. |
@andyzhangx thx for confirming! :) |
8579c0c
to
bd8ca85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, this is so good to see - I can (eventually) reduce the list of things I have to disable as they were enabled by default.
Only concern would be teams that may depend on this. We will need to make sure that this is called out expressly in the release notes as a "breaking" change and that the user would need to expressly enable these addons if they wanted to continue to use them.
@Michael-Sinz the current release CI allows project maintainers to edit and curate the release notes before merging to the release branch (that merge acts as a gate to actually validate and publish release artifacts). So you'll have a chance to weigh in then to ensure we're doing sufficient communication. |
Will have to see how that works out - I hope it gives hints as to what all of the changes were from the prior release. |
Reason for Change:
This PR changes the default addons installation flow so that the following addons are no longer installed by default:
The above addons will be disabled by default because they have been deprecated in favor of alternate solutions
The above addon will be disabled by default because it is no longer actively maintained, and the preferred maintenance gesture is to use the official helm chart.
Issue Fixed:
Credit Where Due:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Requirements:
Notes: