Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: always install GPU drivers during bootstrapping #4634

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR restores the previous behavior of always installing GPU drivers during bootstrapping. This has the side-effect of no longer supporting "airgap" scenarios, but it appears that simply apt-get download'ing the packages during VHD creation is not sufficient for providing that solution. I am speculating that files in /var/cache/apt/archives/ are regularly cleaned up based on the age of the files, which means that pre-downloaded apt packages in the VHD are only viable for a temporary period of time.

Issue Fixed:

Fixes #4631

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@jackfrancis
Copy link
Member Author

cc @Michael-Sinz

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

CI seems happy with this.

@jackfrancis jackfrancis merged commit 637e2c6 into master Aug 31, 2021
@jackfrancis jackfrancis deleted the gpu-always-download branch August 31, 2021 16:46
@Michael-Sinz
Copy link
Collaborator

We should look into what happened here - the files don't magically go away unless some code ran. The image does not run again until bootstrap is running so the image cache had to have been flushed somehow.

Either that or the actual packages changed somehow. Given that this image once did work, something changed to make it not work and that change had to be external to the image.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU nodes fail with CSE error 86
3 participants