Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget setting gets reset and is not applied #1123

Closed
ZarTrox opened this issue Jan 19, 2021 · 4 comments · Fixed by #1193
Closed

Widget setting gets reset and is not applied #1123

ZarTrox opened this issue Jan 19, 2021 · 4 comments · Fixed by #1193
Labels
P1 High-priority issues. (t) Bug Bug reports (actual behavior is different than the expected behavior). (u) Paperbits Issues, which require changes in the Paperbits libraries.

Comments

@ZarTrox
Copy link

ZarTrox commented Jan 19, 2021

Bug description

When creating a new link with the Setting "Link opens in" set to "New Window" it resets most of the time. (See Gif) In the end it still opens in the same window.
On a side note: Sometimes it even resets the link target, but this is not reproduceable.

Expected behavior

If something is set and saved it should not be reset.

Is your portal managed or self-hosted?

Managed

Additional context

2021-01-19_09-47-50

@mikebudzynski mikebudzynski added (t) Bug Bug reports (actual behavior is different than the expected behavior). (u) Paperbits Issues, which require changes in the Paperbits libraries. P1 High-priority issues. labels Jan 20, 2021
@azaslonov
Copy link
Member

Hi @ZarTrox, the option "Open in new window" works in the published portal only. Do you want it to open in a new window in design mode as well? If yes, what is expected behavior, another designer window?

@azaslonov azaslonov added the Response needed Issues, which require a response from the author. label Mar 10, 2021
@AnRei123
Copy link

Hi Alex, I wonder that you seem not to be able to reproduce the issue described above.
For our environments, open in new window works VERY sporadically for only VERY VIEW images. For most of them 95% it does permanently not work even after reconfiguring the setting. This behavior has been tested for our environments in the published mode several times for the same link after correcting the lost settings again and publishing again and again.
If you download the data.json file, you can see that the setting is mostly not reflected there! Even after setting the flag "Open in new window" again and gain. It is therefore very disgusting, especially for external links, portal users loose the focus of the portal and will walk away to external contents. Here it is very essential for us that links to external web contents would always open a new browser tab or new broswser window. But there are also other link examples where we do like to open the target not on the same browser tab card.
In the video above, we did not publish the portal as the GUI does not remember the setting in the GUI after refreshing the page. Even if you save the page and download the data.json file, you can see that the "_blank" value is not added according to the previous configuration in the GUI.

@azaslonov
Copy link
Member

Hi Angelika (@AnRei123), I found a few cases today indeed, fixed some of them and working on the others. I won't be able to push it in the ongoing release, but will do it for the next one.

@azaslonov azaslonov removed the Response needed Issues, which require a response from the author. label Mar 16, 2021
@azaslonov
Copy link
Member

Fixed all cases, releasing soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High-priority issues. (t) Bug Bug reports (actual behavior is different than the expected behavior). (u) Paperbits Issues, which require changes in the Paperbits libraries.
Projects
None yet
4 participants