Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the new, non-preview API version #300

Closed
ashemedai opened this issue Nov 11, 2019 · 4 comments
Closed

Migrate to the new, non-preview API version #300

ashemedai opened this issue Nov 11, 2019 · 4 comments
Labels
P1 High-priority issues. (t) Improvement Requests for iterative improvements on existing functionality.

Comments

@ashemedai
Copy link

Describe the bug
The wiki in this repository mentions the use of "managementApiVersion": "2018-06-01-preview" a few times.

To Reproduce
Steps to reproduce the behavior:

  1. Go to wiki
  2. Click on self-hosting the portal
  3. Scroll down to Step 2: Configure
  4. See error

Expected behavior
Expected to see "managementApiVersion": "2019-01-01" as per visiting https://docs.microsoft.com/en-us/rest/api/apimanagement/ and folding open the Reference to see GA versions.

Portal environment
N/A

Release tag or commit SHA (if using self-hosted version)
N/A

API Management service name
N/A

Environment
N/A

@ashemedai ashemedai added (t) Bug Bug reports (actual behavior is different than the expected behavior). to-triage labels Nov 11, 2019
@mikebudzynski mikebudzynski removed (t) Bug Bug reports (actual behavior is different than the expected behavior). to-triage labels Nov 12, 2019
@mikebudzynski
Copy link
Contributor

@ashemedai Thanks for opening this issue. Migrating to the new API version is one our roadmap.

@mikebudzynski mikebudzynski removed their assignment Nov 12, 2019
@mikebudzynski mikebudzynski changed the title Wiki: API preview, deprecate in favour of release? Migrate to the new, non-preview API version Nov 12, 2019
@ashemedai
Copy link
Author

@mikebudzynski Awesome to hear. I did try the 2019-01-01 API calls yesterday to retrieve the various data of a portal I clicked together and it all worked as it should (which shouldn't be a surprise, but still nice to know hopefully). I might actually write a blog post about this.

As an aside: awesome work on the new portal.

@mikebudzynski
Copy link
Contributor

Thanks, @ashemedai! Although the endpoint works, we still need to document the API here before we switch the versions.

@azaslonov azaslonov added the (t) Improvement Requests for iterative improvements on existing functionality. label Jan 16, 2020
@mikebudzynski mikebudzynski added the P1 High-priority issues. label Jun 15, 2020
@mikebudzynski
Copy link
Contributor

Closed with #819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High-priority issues. (t) Improvement Requests for iterative improvements on existing functionality.
Projects
None yet
Development

No branches or pull requests

3 participants