Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name not always displayed in azureresourceschema #51

Open
tfitzmac opened this issue Jul 17, 2019 · 6 comments
Open

name not always displayed in azureresourceschema #51

tfitzmac opened this issue Jul 17, 2019 · 6 comments

Comments

@tfitzmac
Copy link

When I use the command:
autorest -Modeler Swagger -CodeGenerator AzureResourceSchema

The markdown files do not always include the description of the name property for the resource type. Here is an example of a resource type that doesn't include the name description - CDN profile.

However, other resource types include the name description, such as storage account.

@tfitzmac
Copy link
Author

@jhendrixMSFT - here is a request for an update to the AzureResourceSchema module.

@fearthecowboy fearthecowboy transferred this issue from Azure/autorest Nov 8, 2019
@anthony-c-martin
Copy link
Member

Markdown support was actually pulled out as part of the move to v3. Sounds like this is still needed!

@tfitzmac
Copy link
Author

Yes, I generate the template reference docs with this module. I added a work around for the issue with the name not showing up for some resource types. It sounds like I should be cautious about updating my installed version.

@ifeoluwaokunoren
Copy link

@anthony-c-martin can you please help resolve this?
Thanks.

@tfitzmac
Copy link
Author

tfitzmac commented Dec 5, 2019

The other question to consider is whether using the swagger files is still the best option now that the schema files are being kept up-to-date. One problem I have right now is that polymorphic objects are not generated correctly from the current module. So, we need to change the module for polymorphic objects, and it's made we wonder if it should be completely redeveloped.

@anthony-c-martin - do you have a recommendation about whether swagger or schemas would be easier to work with? Particularly with regards to handling polymorphic objects.

@anthony-c-martin
Copy link
Member

@tfitzmac Support for polymorphism is much better now as we've had to make a few fixes for schema generation. Those fixes are only in v3 however, which conveniently doesn't support the doc generation.

For the question on swagger vs schemas, I think it depends on what you're doing with the documentation. If you're just describing APIs, then swagger for sure. If you're generating docs to show the template schema, then it probably makes more sense to keep it here and integrate with the latest changes - that way the docs & actual schemas would be more in sync, plus we're not reinventing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants