Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Pin Node to 18.13.0" when build agents are upgraded to 18.14.2 #3130

Closed
mikeharder opened this issue Feb 16, 2023 · 0 comments · Fixed by #3208
Closed

Revert "Pin Node to 18.13.0" when build agents are upgraded to 18.14.2 #3130

mikeharder opened this issue Feb 16, 2023 · 0 comments · Fixed by #3208
Assignees
@mikeharder
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@mikeharder
Copy link
Member

mikeharder commented Feb 16, 2023 •
edited
Loading

When using Node 18.14.0 or 18.14.1 with npm 9.3.1, pipeline "autorest.csharp" fails with the following error:

error TS2688: Cannot find type definition file for 'mocha'.
  The file is in the program because:
    Entry point of type library 'mocha' specified in compilerOptions

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2171100&view=logs&j=45f9faef-ad3a-5235-6d52-a4da1b0ab954&s=45a4dd8c-d89a-566b-d89f-6724086326ec&t=9a8cf63c-b194-5fc6-b9a6-f445bb38c677&l=37

I verified this is due to nodejs/node#46542, and is fixed in npm 9.4.2 (#3133).

Node 18.14.2 was released today and should fix this issue. Since this repo already pinned to Node 18.13.0 (#3097), I think the best approach is to wait until our build agents have upgraded to Node 18.14.2, then revert #3097.
@mikeharder mikeharder added the Central-EngSys This issue is owned by the Engineering System team. label Feb 16, 2023
@mikeharder mikeharder self-assigned this Feb 16, 2023
@mikeharder mikeharder moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Feb 16, 2023
@mikeharder mikeharder mentioned this issue Feb 16, 2023
Closed
@mikeharder mikeharder changed the title Cannot find type definition file for 'mocha'. Cannot find type definition file for 'mocha' when using npm@9 Feb 16, 2023
@mikeharder mikeharder changed the title Cannot find type definition file for 'mocha' when using npm@9 Upgrade to Node 18 with npm >= 9.4.2 Feb 17, 2023
@mikeharder mikeharder changed the title Upgrade to Node 18 with npm >= 9.4.2 Revert "Pin Node to 18.13.0" when build agents are upgraded to 18.14.2 Feb 22, 2023
@mikeharder mikeharder mentioned this issue Mar 17, 2023
Merged
@mikeharder mikeharder moved this from 🐝 Dev to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Mar 17, 2023
@github-project-automation github-project-automation bot moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeharder mikeharder

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
1 participant
@mikeharder