Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the C# generator update PR in the main repo #807

Closed
pakrym opened this issue Jun 10, 2020 · 0 comments
Closed

Merge the C# generator update PR in the main repo #807

pakrym opened this issue Jun 10, 2020 · 0 comments
Assignees
Labels
v3 Version 3 of AutoRest C# generator.
Milestone

Comments

@pakrym
Copy link
Contributor

pakrym commented Jun 10, 2020

Every time we merge a change to the generator the automation runs and re-generates code in the azure-sdk-for-net repo.

Example PR: Azure/azure-sdk-for-net#12692

Sometimes code is ready to merge as is but sometimes it needs a few adjustments to get building.

Examples:

  1. Export-API if public generated APIs changed. Make sure the changes are reasonable.
  2. Code fixes if there were generator changes incompatible with the existing code

To make changes to the automated branch:

Do this once:

git remote add azure-sdk git@github.com:azure-sdk/azure-sdk-for-net.git
git fetch azure-sdk
git checkout -b auto-update-autorest --track azure-sdk/auto-update-autorest

Do this for every new PR:

git fetch azure-sdk
git checkout -B auto-update-autorest --track azure-sdk/auto-update-autorest
<... make changes ...>
git add .
git commit -m "..."
git push

This would update the PR with existing changes.

NOTE: Keep in mind that every merged generator change would REWRITE the branch discarding manual changes so we might need to be strategic about it.

@pakrym pakrym added the v3 Version 3 of AutoRest C# generator. label Jun 10, 2020
@pakrym pakrym added this to the [2020] July milestone Jun 10, 2020
@pakrym pakrym closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Version 3 of AutoRest C# generator.
Projects
None yet
Development

No branches or pull requests

3 participants