-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated packages should use the latest version of @microsoft/api-extractor #1204
Comments
Hey @JonathanCrd Can you pick this one up? cc @sarangan12 |
Feel free to create a separate issue for my suggestion if you think it's worth exploring or ignore it if you think it's a terrible idea 😄 |
Let's use this issue to just update the dependency version for api extractor |
I noticed in passing that there are a bunch of outdated dependencies assuming I'm looking at the right file autorest.typescript/src/generators/static/packageFileGenerator.ts Lines 153 to 166 in cf844d9
Like core-tracing should be preview.13, core-http should be 2.x etc - should we update those as well in this change? I can edit the issue if so |
PR #1207 updates @microsoft/api-extractor to ^7.18.11 @ramya-rao-a should I also update the outdated dependencies that @maorleger pointed out? |
@JonathanCrd Yes, please use the same PR to make the updates for the other outdated dependencies. |
Please update the code gen for package.json to pull in the latest version of @microsoft/api-extractor (currently ^7.18.11).
This PR is handling updating existing packages.
Suggestion: consider reading and parsing the dependencies / devDependencies sections in https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/template/template/package.json - an intersection of those entries with what is being generated can provide better syncing between the two repos. What do you think?
Might not work for all dependencies (for example core-http vs coreV2) but we can have a allowlist of dependencies that should pull their version from the template project
The text was updated successfully, but these errors were encountered: