Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA autorest.typescript v6 #1631

Closed
2 tasks
jeremymeng opened this issue Oct 24, 2022 · 9 comments · Fixed by #1807
Closed
2 tasks

GA autorest.typescript v6 #1631

jeremymeng opened this issue Oct 24, 2022 · 9 comments · Fixed by #1807
Assignees

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Oct 24, 2022

Release a GA version of autorest.typescript v6. It's currently in RC.

  • bump version
  • update package status in README
@joheredi
Copy link
Member

@qiaozha, @sarangan12 do you have any concerns about releasing a stable version? We are already GAing libraries generated with the current generator so I think it should be fine to release 6.0.0

@sarangan12
Copy link
Contributor

I am fine with the GA

@qiaozha
Copy link
Member

qiaozha commented Nov 1, 2022

I think there're still some issues left that I can think of in HLC. Wonder if we should resolve them first and then release the GA version.

  1. Credential scopes in government cloud [HLC] Remove the default credential scope code and update the scope by using options enriched from core lib #1597
  2. Remove the appended 204 code [HLC] Remove the appended 204 response code when the operation is LRO #1537
  3. Tyoe name inconsistent with swagger definition [mgnt] Type choice name is not matched between definition and reference if name is all uppercase #1404
  4. Parameter order issue Update Codegen to generate operation with parameters in the right position #1529

@qiaozha
Copy link
Member

qiaozha commented Nov 1, 2022

@MaryGao @lirenhe Do you think we should start fixing those mgmt sample generation issue before the GA #1479

@lirenhe
Copy link
Member

lirenhe commented Nov 1, 2022

@MaryGao @lirenhe Do you think we should start fixing those mgmt sample generation issue before the GA #1479

We already generate stable version SDK so I am good with GA v6. We could fix those issues in future release.

@qiaozha
Copy link
Member

qiaozha commented Nov 1, 2022

I think there're still some issues left that I can think of in HLC. Wonder if we should resolve them first and then release the GA version.

  1. Credential scopes in government cloud [HLC] Remove the default credential scope code and update the scope by using options enriched from core lib #1597
  2. Remove the appended 204 code [HLC] Remove the appended 204 response code when the operation is LRO #1537
  3. Tyoe name inconsistent with swagger definition [mgnt] Type choice name is not matched between definition and reference if name is all uppercase #1404
  4. Parameter order issue Update Codegen to generate operation with parameters in the right position #1529

I think issue #1537 and #1404 and #1529 will cause SDK breaking change.

@qiaozha
Copy link
Member

qiaozha commented Nov 4, 2022

I think there're still some issues left that I can think of in HLC. Wonder if we should resolve them first and then release the GA version.

  1. Credential scopes in government cloud [HLC] Remove the default credential scope code and update the scope by using options enriched from core lib #1597
  2. Remove the appended 204 code [HLC] Remove the appended 204 response code when the operation is LRO #1537
  3. Tyoe name inconsistent with swagger definition [mgnt] Type choice name is not matched between definition and reference if name is all uppercase #1404
  4. Parameter order issue Update Codegen to generate operation with parameters in the right position #1529

@joheredi I think all these issues have been resolved. You may release the GA version of @autorest/typescript now. Just need to make sure you will also release a new version for rlc-common and cadl-typescript.

@jeremymeng
Copy link
Member Author

Thanks all!

@qiaozha
Copy link
Member

qiaozha commented Apr 12, 2023

released here https://www.npmjs.com/package/@autorest/typescript/v/6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants