Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client options naming gaps and no $host parameter between HLC and modular #2633

Closed
Tracked by #2638
MaryGao opened this issue Jun 28, 2024 · 1 comment · Fixed by #2671
Closed
Tracked by #2638

Client options naming gaps and no $host parameter between HLC and modular #2633

MaryGao opened this issue Jun 28, 2024 · 1 comment · Fixed by #2671
Assignees
@MaryGao
Labels
HRLC p0 priority 0

Comments

@MaryGao
Copy link
Member

MaryGao commented Jun 28, 2024 •
edited
Loading

There are two gaps for client options

  • The naming rule is different between them
  • There is no $host option in modular but with one in hlc

Regarding item 1 I prefer to mitigate this gap.
Regarding item 2 after checking we found the $host parameter has no usage in client side or core side so I prefer to accept this breaking.

  • Modular
    image
  • HLC
    image
    image
@MaryGao
Copy link
Member Author

MaryGao commented Jun 28, 2024

/cc @joheredi @qiaozha

@kazrael2119 kazrael2119 mentioned this issue Jul 2, 2024
Closed
@qiaozha qiaozha added HRLC p0 priority 0 labels Jul 3, 2024
@MaryGao MaryGao mentioned this issue Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaryGao MaryGao

Labels
HRLC p0 priority 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the client option naming inconsistancy MaryGao/autorest.typescript
2 participants
@MaryGao @qiaozha