Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tracing generation #892

Closed
3 tasks done
joheredi opened this issue Mar 26, 2021 · 0 comments
Closed
3 tasks done

Update Tracing generation #892

joheredi opened this issue Mar 26, 2021 · 0 comments
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. MVP P3 v6
Milestone

Comments

@joheredi
Copy link
Member

joheredi commented Mar 26, 2021

Update @maorleger is working in this space, we should make sure we snap to what his latest plan for core-tracing GA is.

@richardpark-msft added some changes for open telemetry in the PR: Azure/azure-sdk-for-js#14208

We need to update the generated tracing statements to align with these changes, here are some of the points we may need to address:

  • CanonicalCode.UNKNOWN => SpanStatusCode.ERROR & CanonicalCode.OK => SpanStatusCode.OK
  • Bump @azure/core-tracing dependency version
  • We may need to do something similar in the generated rollup config and it is being done here
@joheredi joheredi added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 26, 2021
@joheredi joheredi added this to the Backlog milestone Mar 26, 2021
@joheredi joheredi added the v6 label Mar 26, 2021
@xirzec xirzec added the MVP label Aug 2, 2021
@sarangan12 sarangan12 added the P3 label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. MVP P3 v6
Projects
None yet
Development

No branches or pull requests

3 participants