Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THE GREAT CODE REORG #1212

Closed
fearthecowboy opened this issue Jun 29, 2016 · 5 comments
Closed

THE GREAT CODE REORG #1212

fearthecowboy opened this issue Jun 29, 2016 · 5 comments
Assignees

Comments

@fearthecowboy
Copy link
Member

fearthecowboy commented Jun 29, 2016

In order to attack MAX_PATH issues, I'm reorganizing the whole repo today.

We have far too much replication in path names, and excessive nesting leads to copy/paste errors when dealing with multiple projects nested inconsistently.

Thomas and I have discussed the options, and we're comfortable with the following layout:

# Title: Rename (and change namespaces!) and put in a subfolder of /src
# Note, this does mean that I have to change NAMESPACES in all the C# code (with Resharper) 
# But this will trim a lot of excessive redundancy from the whole project 

# Core
src\core\AutoRest                                         # was Microsoft.Rest.Generator.Cli , and before that AutoRest
src\core\Autorest.Core                                    # was Microsoft.Rest.Generator
src\core\AutoRest.Core.Tests                              # was Microsoft.Rest.Generator.Tests
src\core\AutoRest.Extensions                              # was Microsoft.Rest.Generator.Extensions      
src\core\AutoRest.Extensions.Azure                        # was Microsoft.Rest.Generator.Extensions.Azure
src\core\AutoRest.Extensions.Azure.Tests                  # was Microsoft.Rest.Generator.Extensions.Azure.Tests
src\core\AutoRest.Extensions.Tests                        # was Microsoft.Rest.Generator.Extensions.Tests

# Generators
src\generator\AutoRest.AzureResourceSchema        # was Microsoft.Rest.Generator.AzureResourceSchema
src\generator\AutoRest.AzureResourceSchema.Tests  # was Microsoft.Rest.Generator.AzureResourceSchema.Tests
src\generator\AutoRest.CSharp                     # was Microsoft.Rest.Generator.CSharp
src\generator\AutoRest.CSharp.Azure               # was Microsoft.Rest.Generator.CSharp.Azure
src\generator\AutoRest.CSharp.Azure.Tests         # was Microsoft.Rest.Generator.CSharp.Azure.Tests
src\generator\AutoRest.CSharp.Tests               # was Microsoft.Rest.Generator.CSharp.Tests
src\generator\AutoRest.CSharp.Unit.Tests          # was Microsoft.Rest.Generator.CSharp.Unit.Tests
src\generator\AutoRest.Java                       # was Microsoft.Rest.Generator.Java
src\generator\AutoRest.Java.Azure                 # was Microsoft.Rest.Generator.Java.Azure
src\generator\AutoRest.NodeJS                     # was Microsoft.Rest.Generator.NodeJS
src\generator\AutoRest.NodeJS.Azure               # was Microsoft.Rest.Generator.NodeJS.Azure
src\generator\AutoRest.NodeJS.Azure.Tests         # was Microsoft.Rest.Generator.NodeJS.Azure.Tests
src\generator\AutoRest.NodeJS.Tests               # was Microsoft.Rest.Generator.NodeJS.Tests
src\generator\AutoRest.Python                     # was Microsoft.Rest.Generator.Python
src\generator\AutoRest.Python.Azure               # was Microsoft.Rest.Generator.Python.Azure
src\generator\AutoRest.Python.Azure.Tests         # was Microsoft.Rest.Generator.Python.Azure.Tests
src\generator\AutoRest.Python.Tests               # was Microsoft.Rest.Generator.Python.Tests
src\generator\AutoRest.Ruby                       # was Microsoft.Rest.Generator.Ruby
src\generator\AutoRest.Ruby.Azure                 # was Microsoft.Rest.Generator.Ruby.Azure                    

# Modelers
src\modeler\AutoRest.CompositeSwagger         # was Microsoft.Rest.Modeler.CompositeSwagger
src\modeler\AutoRest.CompositeSwagger.Tests   # was Microsoft.Rest.Modeler.CompositeSwagger.Tests
src\modeler\AutoRest.Swagger                  # was Microsoft.Rest.Modeler.Swagger
src\modeler\AutoRest.Swagger.Tests            # was Microsoft.Rest.Modeler.Swagger.Tests          

# Developer-time tooling (for tests)
src\dev\TestServer\server\node_modules\autorest-test
src\dev\AutoRest.Tooling.CSharp.Compiler

# client runtimes
src\client\Microsoft.Rest.ClientRuntime
src\client\Microsoft.Rest.ClientRuntime.Azure
src\client\Microsoft.Rest.ClientRuntime.Azure.Authentication
src\client\Microsoft.Rest.ClientRuntime.Azure.Tests
src\client\Microsoft.Rest.ClientRuntime.Etw
src\client\Microsoft.Rest.ClientRuntime.Log4Net
src\client\Microsoft.Rest.ClientRuntime.Tests
src\client\Microsoft.Rest.ClientRuntime.Tracing.Tests
@fearthecowboy fearthecowboy self-assigned this Jun 29, 2016
@hovsepm
Copy link
Contributor

hovsepm commented Jun 29, 2016

@fearthecowboy why Modeler folder is Uppercase? Does that mean anything special? :)

@fearthecowboy
Copy link
Member Author

@hovsepm fat fingers on my part. It's actually lowercase :D

@MichaCo
Copy link

MichaCo commented Nov 7, 2016

@hovsepm @fearthecowboy Hi, didn't want to open a new issue for that question, but where did the src\client\Microsoft.Rest.ClientRuntime code go? The client folder is not there anymore in the master branch. Has that been moved to another project on github or is it not open source anymore?

Thanks!

@fearthecowboy
Copy link
Member Author

It's in the https://github.com/Azure/azure-sdk-for-net repository in the src/clientruntime folder now

@MichaCo
Copy link

MichaCo commented Nov 7, 2016

@fearthecowboy Ahhh thanks a lot ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants