Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readOnly rule to handle OpenAPI 2 polymorphism pattern. #108

Open
mikekistler opened this issue Jan 31, 2023 · 0 comments
Open

Fix readOnly rule to handle OpenAPI 2 polymorphism pattern. #108

mikekistler opened this issue Jan 31, 2023 · 0 comments

Comments

@mikekistler
Copy link
Member

The readOnly rule categorizes schemas as "request" or "response" if they are reachable from an operation request or response body, respectively. But the current logic does not handle the OpenAPI 2 polymorphism pattern, where the parent schema does not reference child schemas directly -- instead, the child schema "allOf"s the parent into itself. As a result, the rule is generating false positives, such as in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant