-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New naming/schema for Firewall Policy #13629
New naming/schema for Firewall Policy #13629
Comments
add to S171 |
Just to give more information. As part of this change, there is a new rule type that will have to be supported: Basically the format for Nat Rule which should get added as part of this would be like this: az network firewall policy rule-collection-group collection rule add --collection-name For rule type NAT Rule, following fields apply: And following fields do not apply And the Nat rule collection command will have to change to: |
Is your feature request related to a problem? Please describe.
The backend schema for the firewall policy is going to change from 2020-05-01 api version. If CLI automatically updates the api version to call a new sdk everytime the sdk is updated, we need to make this change ASAP.
Describe the solution you'd like
Current Scenario:
CLI is consuming the firewall policy schema in the format of RuleGroups, Rules and RuleConditions. However it is shown to the user in the format of RuleCollectionsGroup, RuleCollections and Rule.
Going Forward:
The changes made to map the Rulegroups/Rule/RuleConditions -> RuleCollectionsGroup/RuleCollections/Rules on the CLI side will be moved to the backend. So we need not map this on the CLI side as backend sends the right schema of RuleCollectionsGroup/RuleCollections/Rules starting with the api version 2020-05-01. We need changes on the CLI to consume the new schema
Describe alternatives you've considered
We do not have an alternative as this change is already rolledout on the backend and this is a requirement
Additional context
Swagger Changes for reference: Azure/azure-rest-api-specs#9356.
Please note that the SDK is not released yet. So we will have to generate a local sdk to test the changes and use the api version 2020-05-01 when making the call to get the new schema
The text was updated successfully, but these errors were encountered: