Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for supporting update Virtual Router and get virtual router peer learned routes and advertised routes #16139

Closed
naveenchekuri opened this issue Dec 3, 2020 · 5 comments · Fixed by #16494
Assignees
Labels
feature-request Network az network vnet/lb/nic/dns/etc...
Milestone

Comments

@naveenchekuri
Copy link

Resource Provider

Microsoft.Network

Description of Feature or Work Requested
AZ CLI currently support create and delete virtual router and virtual router peer. We need to add support for following

  1. Support update virtual router to add boolean flag AllowBranchToBranchTraffic. Example powershell is below

"Update-AzVirtualRouter -ResourceGroupName VirtualRouterRG -RouterName virtualrouterhub1 -AllowBranchToBranchTraffic"

When this flag as true by customer, please set allowBranchToBranchTraffic flag under virtualhub. By default this flag is false

  1. Support virtualrouterpeer getlearnedroutes and virtualrouterpeer getadvertisedroutes for az cli. Powershell example below

"Get-AzVirtualRouterPeerAdvertisedRoute -ResourceGroupName VirtualRouterRG -VirtualRouterName virtualrouterhub1 -PeerName peer1"

"Get-AzVirtualRouterPeerLearnedRoute -ResourceGroupName VirtualRouterRG -VirtualRouterName virtualrouterhub1 -PeerName peer1"

Minimum API Version Required**
2020-06-01

Swagger Link
AllowBranchToBranchTraffic flag - Azure/azure-rest-api-specs#11015
Advertised and LearnedRoutes - Azure/azure-rest-api-specs#10434

Target Date
12/25/2020

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Dec 3, 2020
@yonzhan yonzhan added the Network az network vnet/lb/nic/dns/etc... label Dec 4, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Dec 4, 2020
@yonzhan yonzhan added this to the S180 milestone Dec 4, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 4, 2020

Network

@yonzhan yonzhan modified the milestones: S180, S181 Dec 17, 2020
@kairu-ms
Copy link
Contributor

kairu-ms commented Jan 8, 2021

Hi @naveenchekuri. 'az network vrouter' has been renamed by 'az network virtualhub-router', so those features will be added in ' az network virtualhub-router'. Is that make sense?

@naveenchekuri
Copy link
Author

Yes. Thank you. please add these features under ' az network virtualhub-router'

@naveenchekuri
Copy link
Author

@kairu-ms routeserver is the final name change we agreed upon with marketing. please add these features under "az network routeserver"

@kairu-ms
Copy link
Contributor

@kairu-ms routeserver is the final name change we agreed upon with marketing. please add these features under "az network routeserver"

Done

@yonzhan yonzhan modified the milestones: S181, S182 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants