Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to dedicated host group for Ultra SSD support #21997

Closed
hari-bodicherla opened this issue Apr 8, 2022 · 8 comments · Fixed by #22176
Closed

Changes related to dedicated host group for Ultra SSD support #21997

hari-bodicherla opened this issue Apr 8, 2022 · 8 comments · Fixed by #22176
Assignees
Labels
Auto-Assign Auto assign by bot Compute az vm/vmss/image/disk/snapshot feature-request

Comments

@hari-bodicherla
Copy link

Is your feature request related to a problem? Please describe.
we currently don't support VM deployments against the dedicated hosts using ultra SSD capabilities. The ultra SSD capabilities along with host level isolation using dedicated hosts enable our customers to conquer their most IO intensive and extremely scalable workloads along with achieving compliance. Currently, the ultra SSD support for dedicated hosts is enabled only for zonal dedicated host group resources.

Describe the solution you'd like
This change exposes new param customers can use to enable/disable the ultra SSD support for dedicated host group resources so that customers can deploy their ultra SSD enabled VM/VMSS resource on this dedicated host to allocate resources on the ultra SSD support enabled clusters.

Describe alternatives you've considered
N/A

Additional context
The cli command where we need to add this property "UltraSSDEnabled" is in
{ [ az vm host group create ] (https://docs.microsoft.com/en-us/cli/azure/vm/host/group?view=azure-cli-latest#az-vm-host-group-create)}

@ghost ghost added the Compute az vm/vmss/image/disk/snapshot label Apr 8, 2022
@ghost ghost added this to the Backlog milestone Apr 8, 2022
@ghost ghost assigned zhoxing-ms Apr 8, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 8, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 8, 2022

Compute

@zhoxing-ms
Copy link
Contributor

@hari-bodicherla Could you please provide the link of Swagger changes and the specific design of CLI commands and parameters in the issue description?

@hari-bodicherla
Copy link
Author

@hari-bodicherla Could you please provide the link of Swagger changes and the specific design of CLI commands and parameters in the issue description?

Swagger design PR links:
Azure/azure-rest-api-specs#18076 - Main PR
Azure/azure-rest-api-specs#18528 - Minor documentation changes PR for the same feature.

The UltraSSDEnabled property or EnableUltraSSD needs to be added as switch property since this is create time only setting param and it cant be changed after Host creation. The default value can be null in which case CRP assumes the customer want s to set the ultra SSD as false for the dedicated Host and CRP also accepts False or true

@zhoxing-ms
Copy link
Contributor

@hari-bodicherla Could you provide the specific commands and parameter names that we need to support for this feature?

@Jing-song
Copy link
Contributor

Jing-song commented Apr 25, 2022

@hari-bodicherla Could you please provide the link of Swagger changes and the specific design of CLI commands and parameters in the issue description?

Swagger design PR links: Azure/azure-rest-api-specs#18076 - Main PR Azure/azure-rest-api-specs#18528 - Minor documentation changes PR for the same feature.

The UltraSSDEnabled property or EnableUltraSSD needs to be added as switch property since this is create time only setting param and it cant be changed after Host creation. The default value can be null in which case CRP assumes the customer want s to set the ultra SSD as false for the dedicated Host and CRP also accepts False or true

Hi, @hari-bodicherla , These changes have not been officially released to python SDK used by the CLI (https://pypi.org/project/azure-mgmt-compute/#description), please release as soon as possible to ensure that this feature can be released in this sprint.

@hari-bodicherla
Copy link
Author

@hari-bodicherla Could you provide the specific commands and parameter names that we need to support for this feature?

As mentioned in the PR description, we need to add a property like "UltraSSDEnabled" or "EnableUltraSSD" in the below cmdlet

{ [ az vm host group create ] (https://docs.microsoft.com/en-us/cli/azure/vm/host/group?view=azure-cli-latest#az-vm-host-group-create)}%7D)

@vamckMS
Copy link

vamckMS commented Apr 25, 2022

@zhoxing-ms, do you know if this change will make it to the May CLI release? I believe that is the latest release you have, am I right?

@zhoxing-ms
Copy link
Contributor

do you know if this change will make it to the May CLI release? I believe that is the latest release you have, am I right?

Yes, we plan to release it in this sprint (05-24)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Compute az vm/vmss/image/disk/snapshot feature-request
Projects
None yet
5 participants