Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error color makes text unreadable #8483

Closed
StingyJack opened this issue Feb 9, 2019 · 8 comments
Closed

Error color makes text unreadable #8483

StingyJack opened this issue Feb 9, 2019 · 8 comments
Labels

Comments

@StingyJack
Copy link

Describe the bug
I cant read errors using the default console colors for windows 10.
image

I expect to be able to read the error messages when displayed using the defaults for windows 10 console without having to resort to using screenshots and MS Paint's paintbucket to read them (like this)
image

Environment summary
Windows 10, usual updates.

Additional context
Its also caused everything else typed into this prompt to now be unreadable, but I see that is a different bug reported here already.

@tjprescott
Copy link
Member

tjprescott commented Feb 9, 2019

On the Windows console, you can reset the color if it doesn't revert by typing color 7. There is an issue open for that #6080.

@StingyJack
Copy link
Author

@tjprescott - is the DarkRed color that is being displayed (that is not in my console's settings for errors) coming from this utility or from Python?

@tjprescott
Copy link
Member

Well, the colors are set from within the Knack library's logging methods. The implementation there uses the colorama library. There may be some platform differences there in how each color is interpreted (for example, the color for errors is designated as RED, not dark red). However, raw errors might be set by Python itself or otherwise be a property of the shell.

We could explore making the colors customizable in the config file. In the meantime, my suggestion would be to tweak your shell's background color to something that shows better contrast.

@StingyJack
Copy link
Author

StingyJack commented Feb 11, 2019

@tjprescott - found the Knack lib and piggybacked the issue. EDIT for manners: Thanks for the nudge in the right direction. Can this be left open until that is fixed and integrated here?

@tjprescott
Copy link
Member

Yes, we also maintain knack, so thank you for opening the issue there. I'm not certain that that fix alone will address everything, but it should be a step in the right direction.

@adewaleo
Copy link
Contributor

Conceptually, maybe we can add an option to az configure to update logging error / warning colors.

@jiasli
Copy link
Member

jiasli commented Jan 20, 2021

This issue has been fixed. Please see #6080 (comment) for the solution.

@armbraggins
Copy link

Piping the output though cat to stop isatty detection is more of a workaround than a fix.
az config set core.no_color=true works though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants