Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionalBatchOperationResult is missing a mocking constructor. #1048

Closed
joshlang opened this issue Nov 23, 2019 · 2 comments · Fixed by #1050
Closed

TransactionalBatchOperationResult is missing a mocking constructor. #1048

joshlang opened this issue Nov 23, 2019 · 2 comments · Fixed by #1050

Comments

@joshlang
Copy link
Contributor

TransactionalBatchOperationResult has a private parameterless constructor. Please make it protected instead of private. This will let us mock it so we can unit test batch code.
@joshlang joshlang mentioned this issue Nov 23, 2019
Merged
1 task
@j82w
Copy link
Contributor

j82w commented Nov 25, 2019

Thanks for the PR.

@j82w
Copy link
Contributor

j82w commented Dec 3, 2019

3.5.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mocking constructors to TransactionalBatchOperationResult
2 participants
@j82w @joshlang