Tests with [InternalsVisibleTo] don't catch serialization issues.

[joshlang]

There are various issues in which problems are caused by internal types not being deserialized properly. Examples:

#1004
#871

The current tests do not discover the problems because of:

azure-cosmos-dotnet-v3/Microsoft.Azure.Cosmos/src/AssemblyInfo.cs

Line 23 in 65444de

[assembly: InternalsVisibleTo("Microsoft.Azure.Cosmos.Tests" + AssemblyKeys.ProductPublicKey)]

The [InternalsVisibleTo] attribute allows these unit tests to deserialize internal types as if they were public. The unit tests succeed. But outside of these testing assemblies, the calls would fail because they're actually internal.

I would suggest creating a test project which is not referenced by [InternalsVisibleTo] and migrating some of the tests over to it.

[j82w]

I agree that this is causing a lot of issues. I'm working on a PR right now to address this. We do have a backlog item to start running the samples as part of the test, but I'm not sure when that will get prioritized. What ever the solution is there will be tests to prevent any future regressions like this.

[j82w]

Fixed in PR #1105