Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiPolygon class marked internal after PR. #1235

Closed
mcpappas opened this issue Feb 28, 2020 · 0 comments · Fixed by #1239
Closed

MultiPolygon class marked internal after PR. #1235

mcpappas opened this issue Feb 28, 2020 · 0 comments · Fixed by #1239

Comments

@mcpappas
Copy link
Contributor

Describe the bug
The Microsoft.Azure.Cosmos.Spatial.MultiPolygon class is marked internal when issue #70 and associated PR #79 seems to indicate it was made public in version 3.0.0.9-preview. I am considering this a bug because the ensuing PR #136 that made the class internal again contains no indication of motivation, which leads me to believe this was the result of a bad merge or incorrect conflict resolution.

To Reproduce
Attempt to use or reference the Microsoft.Azure.Cosmos.Spatial.MultiPolygon class.

Expected behavior
The Microsoft.Azure.Cosmos.Spatial.MultiPolygon class is publicly accessible.

Actual behavior
Microsoft.Azure.Cosmos.Spatial.MultiPolygon is inaccessible due to its protection level

Environment summary
SDK Version: 3.6.0
OS Version (e.g. Windows, Linux, MacOSX): any

Additional context
@kirankumarkolli seems to have both approved PR #79, and created PR #136, so perhaps he can shed light on whether or not the class was intentionally reverted to being internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant