Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics additional information #2570

Closed
j82w opened this issue Jun 21, 2021 · 7 comments
Closed

Diagnostics additional information #2570

j82w opened this issue Jun 21, 2021 · 7 comments
Assignees
Labels
Diagnostics Issues around diagnostics and troubleshooting feature-request New feature or request

Comments

@j82w
Copy link
Contributor

j82w commented Jun 21, 2021

The current diagnostics can have a lot of pages. This issue is to describe adding a summary to the top the diagnostics to make it easier to root cause.

Example of suggestion:

"TotalRequestStats":{
   "TotalRequests": 2,
   "FailedRequests":0,
   "ThrottledRequests":0,
   "MaxCpuUsage": 25,
   "TotalTimeInMs": 50,
   "TotalServiceProcessingTimeInMs": 30,
   "TotalNetworkingTimeInMs": 40,
   "TotalSdkTimeInMs":10
}
@j82w j82w added Diagnostics Issues around diagnostics and troubleshooting feature-request New feature or request labels Jun 21, 2021
@sourabh1007
Copy link
Contributor

What is the difference between TotalServiceProcessingTimeInMs and TotalNetworkingTimeInMs.

If we all feel like that this information is essential then we can discuss about adding this information in telemetry also.

@j82w
Copy link
Contributor Author

j82w commented Jun 22, 2021

TotalServiceProcessingTimeInMs is the time it took for Cosmos DB backend to process the request. It does not include any networking time like how long it was in the queue waiting to be processed. It's essentially RntbdRequestStats.TransitTime - response.BELatencyInMs

TotalNetworkingTime is the time from when the SDK put the request on the wire and until it got a response.

@ealsur
Copy link
Member

ealsur commented Jun 22, 2021

Adding a summary would greatly simplify the areas where customer can laser-focus on.

@kirankumarkolli
Copy link
Member

How about include the wait-times? (concurrency forced waiting times)

@j82w
Copy link
Contributor Author

j82w commented Jun 22, 2021

@kirankumarkolli can you expand on what you mean by concurrency forced waiting times?

@kirankumarkolli
Copy link
Member

@asketagarwal what else is pending?

@asketagarwal
Copy link
Contributor

#2732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diagnostics Issues around diagnostics and troubleshooting feature-request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants