Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable DefaultTraceListener by default on the .NET SDK #2904

Closed
asketagarwal opened this issue Nov 23, 2021 · 2 comments
Closed

Disable DefaultTraceListener by default on the .NET SDK #2904

asketagarwal opened this issue Nov 23, 2021 · 2 comments
Assignees
@j82w
Labels
feature-request New feature or request
Milestone
2022-JAN

Comments

@asketagarwal
Copy link
Contributor

Currently, the SDK enable the trace listener by default.

azure-cosmos-dotnet-v3/Microsoft.Azure.Cosmos/src/DocumentClient.cs

Line 649 in 8d3fb3e

DefaultTrace.InitEventListener();

This should be disabled by default on the SDK to reduce lock contentions.

How to enable it by choice needs to be discussed.
@sourabh1007 sourabh1007 added the feature-request New feature or request label Nov 24, 2021
@j82w
Copy link
Contributor

j82w commented Dec 1, 2021

Related issue: #2240

@kirankumarkolli kirankumarkolli added this to the Jan 2022 milestone Dec 13, 2021
@j82w
Copy link
Contributor

j82w commented Dec 13, 2021

Closed in: #2926

@j82w j82w closed this as completed Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
feature-request New feature or request
Projects
None yet
Milestone
2022-JAN
Development

No branches or pull requests
4 participants
@sourabh1007 @kirankumarkolli @j82w @asketagarwal