Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party document. #3667

Closed
AASPLLC opened this issue Jan 25, 2023 · 5 comments · Fixed by #3864
Closed

3rd party document. #3667

AASPLLC opened this issue Jan 25, 2023 · 5 comments · Fixed by #3864
Assignees

Comments

@AASPLLC
Copy link

AASPLLC commented Jan 25, 2023

This is actually just a simple question. Do we have to keep the 3rd party document (ThirdPartyNotice.txt) in every cosmos project?
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/ThirdPartyNotice.txt

@bartelink
Copy link
Contributor

bartelink commented Jan 26, 2023

i.e. is the copying of that file as Content in the nuget package intentional, or should it be changed to None in order to stop a link to it leaking into all projects referencing it?

image

@ealsur
Copy link
Member

ealsur commented Jan 26, 2023

@philipthomas-MSFT Could you take a look to see what is the purpose of the file and if we are bundling it correctly?

@walliski
Copy link

Its a major annoyance that it shows up in all Projects that references the Cosmos NuGet. I haven't found a good way to remove it for all developers either, as the Path for it is the users' NuGet cache in their home folder.

@Pilchie
Copy link
Member

Pilchie commented May 16, 2023

I think the issue here is that this file shouldn't be in the "content" or "contentFiles" folders of the package. Instead it should just be a loose file in the root of the nupkg, similar to Icon.png.

@bartelink
Copy link
Contributor

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
6 participants