Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rntbd Connection - Health Check Improvements #3773

Closed
kundadebdatta opened this issue Mar 22, 2023 · 0 comments · Fixed by #3835
Closed

Rntbd Connection - Health Check Improvements #3773

kundadebdatta opened this issue Mar 22, 2023 · 0 comments · Fixed by #3835
Assignees
Labels
direct package Engineering engineering improvements (CI, tests, etc.) improvement Change to existing functional behavior (perf, logging, etc.)

Comments

@kundadebdatta
Copy link
Member

This task proposes adding more aggressive timeout check in the Rntbd connection health check.

The current flow:

  • Per connection, if there are 3 consecutive request timeout within 65s, then connection will be closed.

Improvements proposed:

  • If the last request time is 65 seconds ago or any threshold configured, close on first timeout
  • On primary replicas, close connections more aggressively (first timeout + 5.5s/6s/configured threshold) or Math.max (3 times request timeout, 6 seconds)
  • These aggressive closure should be a opt-in behavior for now
@kundadebdatta kundadebdatta added Engineering engineering improvements (CI, tests, etc.) improvement Change to existing functional behavior (perf, logging, etc.) direct package labels Mar 22, 2023
@kundadebdatta kundadebdatta self-assigned this Mar 22, 2023
@kundadebdatta kundadebdatta moved this to Approved in Azure Cosmos SDKs Mar 22, 2023
@kundadebdatta kundadebdatta moved this from Approved to In Progress in Azure Cosmos SDKs May 9, 2023
@ghost ghost closed this as completed in #3835 Jun 10, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure Cosmos SDKs Jun 10, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
direct package Engineering engineering improvements (CI, tests, etc.) improvement Change to existing functional behavior (perf, logging, etc.)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant