Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Feed / Processor: Add Container Resource Id to type FeedRange. #4696

Open
philipthomas-MSFT opened this issue Sep 17, 2024 · 0 comments
Assignees
Milestone

Comments

@philipthomas-MSFT
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The problem is that in some cases, trying to determine whether retries or refreshes to container cached calls from the container (container calling itself) require retries and refreshes based on FeedRanges that have no knowledge of the container it actually originated from. This is exclusive to CF/P.

Describe the solution you'd like
Include Container resource id on the types derive from FeedRange. Understand the impact of change. Have an exhaustive list of test cases to support this. So when FeedRanges are passed into any container methods, we can determine if that FeedRange exists on that container and perform at least one refresh and retry on the container to check its staleness.

Describe alternatives you've considered
Change feed context core type can include the Container resource id since it currently has the FeedRange, so you can make the correlation there, but other methods on the container that use FeedRange as an argument to a parameter, would need to overload to include the container resource id. Less intrusive approach on the FeedRange type, but more intrusive to other methods. An assessment must be made.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants