Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.46.0 Release Notes/Changelog references incorrect property name #4912

Closed
ctompkins-bestpass opened this issue Nov 27, 2024 · 1 comment · Fixed by #4918
Closed

3.46.0 Release Notes/Changelog references incorrect property name #4912

ctompkins-bestpass opened this issue Nov 27, 2024 · 1 comment · Fixed by #4918
Assignees
Labels
customer-reported Issue created by a customer needs-investigation

Comments

@ctompkins-bestpass
Copy link

Describe the bug
The release notes and changelog for v3.46.0 says to set property "DisableNewtonsoftJsonCheck" to true however that does not work and the actual property name to set is "AzureCosmosDisableNewtonsoftJsonCheck".

To Reproduce
In project's csproj, set:

  <PropertyGroup>
    <DisableNewtonsoftJsonCheck>true</DisableNewtonsoftJsonCheck>
  </PropertyGroup>

And build error remains. Change to "AzureCosmosDisableNewtonsoftJsonCheck" and build error disappears.

Expected behavior
The release notes and changelog should reference the correct property to reduce confusion.

Actual behavior
Using the incorrect property name from the release notes and changelog fails to resolve the build failure.

Environment summary
SDK Version: 3.46.0
Windows

Additional context
I believe the property name was updated during development and PR review but notes were not changed after property name was updated. Actual build error message does include the correct property name.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issue created by a customer label Nov 27, 2024
@ctompkins-bestpass ctompkins-bestpass changed the title 3.46.0 Release Notes/Changelog references incorrect propery 3.46.0 Release Notes/Changelog references incorrect property Nov 27, 2024
@ctompkins-bestpass ctompkins-bestpass changed the title 3.46.0 Release Notes/Changelog references incorrect property 3.46.0 Release Notes/Changelog references incorrect property name Nov 27, 2024
@aavasthy
Copy link
Contributor

aavasthy commented Dec 2, 2024

Updated changelog and release notes with the correct property name as part of this PR #4918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issue created by a customer needs-investigation
Projects
None yet
2 participants