Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Stream > Rate limiting #690

Closed
ealsur opened this issue Aug 14, 2019 · 3 comments · Fixed by #1074
Closed

Bulk Stream > Rate limiting #690

ealsur opened this issue Aug 14, 2019 · 3 comments · Fixed by #1074
Assignees
Labels
Bulk feature-request New feature or request

Comments

@ealsur
Copy link
Member

ealsur commented Aug 14, 2019

Ref #585

Current rate limiter is based on single concurrent request per Range. Further customization of that limiter is desirable to achieve greater performance.

@ealsur ealsur added the feature-request New feature or request label Aug 14, 2019
@ealsur ealsur self-assigned this Aug 14, 2019
@ealsur ealsur mentioned this issue Aug 14, 2019
1 task
@ealsur ealsur added the Batch Batch related issue label Aug 14, 2019
@kirankumarkolli
Copy link
Member

Currently only client side buffering is serial per key-range, where as processing the batch is parallel.
And the serial part doesn't include T -> Stream conversion which is a significant part. With-out it its worth validating the requirements once.

@ealsur
Copy link
Member Author

ealsur commented Oct 17, 2019

What is not yet clear is if we want a Rate limiting based on RU/s (which would need to be across all key-ranges) or at the request-per-key-range level.

@kirankumarkolli
Copy link
Member

Got it. I mis-interpreted it.

@ealsur ealsur added Bulk and removed Batch Batch related issue labels Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bulk feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants