Availability: Fixes retry behavior on HttpException #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
bchong95,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When users are using PreferredRegions, and an HttpException arises that marks the current region unavailable, the region is marked unavailable, which moves it to the bottom of the priority list.
In a scenario where the account has 2 regions marked as preferred, and a read request failed with HttpException, the algorithm was, after marking the region unavailable, selecting to retry on the second region in the list, which is basically the one that failed because marking it unavailable moved it to the bottom of the list.
This PR slightly changes the logic to always pick the first preferred region on this scenario, which would be the next preferred region after the current one is marked unavailable.
Type of change
Please delete options that are not relevant.