-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue] azd init
should inspect dockerfile ARGS
#4606
Comments
We are following up on this issue. cc @rajeshkamal5050 |
@weikanglim My current approach is to add a function that extracts the parameters following If there are no problems, please review this PR #4639. |
After reading more about Docker build args, I feel that the UX we're delivering here may be unintuitive to a Docker user. An observation here is that Docker build args are meant to be used as a passed-in CLI flag, in the docs: From this, I wonder if it's weird then for SuggestionWould it be more idiomatic to allow for That way we avoid having this needing configuration upfront. If assuming that we mean to change the semantics of
Creating a |
Output from
azd version
1.11
Describe the bug
My Docker files require some arguments.
The Azure.Yaml Docker file buildArgs is nice once you get it, but isn't very intuitive on how to set up the build args.
It would be great if the AZD init process determined what Args are in the Docker file. And then automatically added them to the azure yaml file.
Final azure.yaml I created:
My Dockerfile with the ARGS
The text was updated successfully, but these errors were encountered: