Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki entry on how to build this repo would be appreciated #2018

Open
IanKemp opened this issue Jun 3, 2020 · 5 comments
Open

Wiki entry on how to build this repo would be appreciated #2018

IanKemp opened this issue Jun 3, 2020 · 5 comments
Assignees
Milestone

Comments

@IanKemp
Copy link

IanKemp commented Jun 3, 2020

It seems you need go installed and on the system PATH, as well as .NET Core 2.2 (why not 3.1?).

@anthonychu
Copy link
Member

@ahmelsayed Do you have any developer guides that we can add to the wiki? @mattchenderson FYI for contributor guide.

@anthonychu anthonychu added this to the Triaged milestone Jun 9, 2020
@IanKemp
Copy link
Author

IanKemp commented Jun 15, 2020

BTW, the reason I'd like this info: I am able to build this repo, but the sizes and versions of the output files are completely different to those available for download here. In other words, what I'm building doesn't seem to be the same as what Microsoft is building. This does not give me confidence in either my build environment or Microsoft's.

@ahmelsayed
Copy link
Contributor

Are you building dev branch or the v3.x branch? the dev branch should be on .netcore 2.2, and v3.x is on 3.1. The build project though hasn't been updated in the v3 branch, I opened these PRs (#2035, #2034)

Usually when I'm testing locally I just do

$ dotnet publish -p src/Azure.Functions.Cli/Azure.Functions.Cli.csproj --runtime linux-x64|win-x64 --output /tmp

$ /tmp/func

but that will only build the .net components and doesn't package the cli correctly.

to create the packages you can use

cd build 
dotnet run skip:Test skip:UploadToStorage skip:TestPreSignedArtifacts skip:CopyBinariesToSign

# The PR above should make all those skips optional

@IanKemp
Copy link
Author

IanKemp commented Jun 16, 2020

Are you building dev branch or the v3.x branch? the dev branch should be on .netcore 2.2, and v3.x is on 3.1. The build project though hasn't been updated in the v3 branch, I opened these PRs (#2035, #2034)

Usually when I'm testing locally I just do

$ dotnet publish -p src/Azure.Functions.Cli/Azure.Functions.Cli.csproj --runtime linux-x64|win-x64 --output /tmp

$ /tmp/func

but that will only build the .net components and doesn't package the cli correctly.

to create the packages you can use

cd build 
dotnet run skip:Test skip:UploadToStorage skip:TestPreSignedArtifacts skip:CopyBinariesToSign

# The PR above should make all those skips optional

That's helpful, thank you, but it's still not providing the output I expect.

For example, when building the v3.x branch, the Microsoft.Azure.WebJobs.Script.dll in the artifacts directory is version 3.0.13614, but the latest version of the host runtime is 3.0.13901. Further, version 3.0.13760 is currently deployed to Azure and already marked for removal. So not only is the Core Tools repo using a version older than the version in the Functions Host repo, it's using a version older than that which is scheduled for removal from Azure.

I had assumed that the reason I was getting such an old version is because I was building this repo incorrectly, but that doesn't seem to be the case. Please can you help me understand the version mismatch?

(The reason I need 3.0.13901 is because it fixes this bug which is currently impacting me.)

@IanKemp
Copy link
Author

IanKemp commented Jun 16, 2020

OK, missing step was to update Azure.Functions.Cli.csproj to have the desired version of Microsoft.Azure.WebJobs.Script.WebHost. After a bit more messing around with cleaning, I now have binaries that do what I need.

@ahmelsayed ahmelsayed self-assigned this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants