Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer: Refactor FunctionAnalyzer #1402

Closed
amdeel opened this issue Jul 1, 2020 · 0 comments · Fixed by #1634
Closed

Analyzer: Refactor FunctionAnalyzer #1402

amdeel opened this issue Jul 1, 2020 · 0 comments · Fixed by #1634
Assignees
@amdeel
Labels
analyzer Issues with the Roslyn analyzer

Comments

@amdeel
Copy link
Contributor

amdeel commented Jul 1, 2020

Currently, we do not store activity function calls (CallActivity*) when code is used in a method that is not labeled a function. This is to prevent test code from being flagged. However, if an orchestrator calls another method where CallActivity* is used, the FunctionAnalyzer will not store these calls either.

This refactor would fix that case so that the FunctionAnalyzer would run on code of methods used inside an orchestrator function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amdeel amdeel

Labels
analyzer Issues with the Roslyn analyzer
Projects
None yet
Milestone
No milestone
1 participant
@amdeel