Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC]Implement InvocationCancel #4027

Closed
pragnagopa opened this issue Jan 29, 2019 · 6 comments
Closed

[RPC]Implement InvocationCancel #4027

pragnagopa opened this issue Jan 29, 2019 · 6 comments

Comments

@pragnagopa
Copy link
Member

Need to implement InvocationCancel
This specifically impacts language workers that start in placeholder mode as language worker process will not restart as part of jobhost restarts.

From issue #1319,
TIMEOUT
A language worker should handle Function timeout/cancelation messages
A language worker should ACK if the Function gracefully timed out based on a configurable grace period
A language worker should provide a means for a Function to be notified of graceful shutdown
The host should send the timeout/cancelation message for a given Function execution to the language worker processing it
A language worker should wait for an ACK for a configurable grace period
The grace period should be configurable via the host.json (timeoutGracePeriod)
The grace period can be overridden per Function via function.json (timeoutGracePeriod)
The default grace period should be 1 second

@pragnagopa
Copy link
Member Author

@yojagad - this is related to issue #5391 . Please take a quick look if this message can be useful to send to worker process to indicate invocation is timeout.

@fabiocav
Copy link
Member

Moving to 72 for investigation as this may no longer be needed.

@liliankasem
Copy link
Member

@yojagad @fabiocav was this investigated at all? Do we still need this?

@pragnagopa
Copy link
Member Author

Tagging @soninaren - as he was looking to extend the support for CancellationToken to out-of-proc languages

@soninaren
Copy link
Member

soninaren commented Feb 24, 2022

I believe this is still relevant. It may not be a cancellation token the functionality is still needed. It would need some design work to start with.

@liliankasem liliankasem removed this from the Triaged milestone Feb 24, 2022
@fabiocav
Copy link
Member

fabiocav commented Mar 9, 2022

Duplicate of #2152

@fabiocav fabiocav marked this as a duplicate of #2152 Mar 9, 2022
@fabiocav fabiocav closed this as completed Mar 9, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants