Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placeholder]Placeholders with out Run From Zip #4534

Open
pragnagopa opened this issue Jun 4, 2019 · 2 comments
Open

[Placeholder]Placeholders with out Run From Zip #4534

pragnagopa opened this issue Jun 4, 2019 · 2 comments
Assignees

Comments

@pragnagopa
Copy link
Member

On FileChangeEvents, JobHost is restarted: https://github.com/Azure/azure-functions-host/blob/dev/src/WebJobs.Script.WebHost/FileMonitoringService.cs#L124

During specialization, JobHost is restarted here: https://github.com/Azure/azure-functions-host/blob/dev/src/WebJobs.Script.WebHost/Standby/StandbyManager.cs#L86

FunctionDispatcher uses a language worker process that is started in placeholder mode if one is available: https://github.com/Azure/azure-functions-host/blob/dev/src/WebJobs.Script/Rpc/FunctionRegistration/FunctionDispatcher.cs#L163

In order to support file edits for languages where user provides a script: python, nodejs and powershell , JobHost restart should recycle placeholder language worker process anytime file edits happen after specialization. But during specialization language worker process should not be killed.

Related issues #4511, #3415

cc: @fabiocav @mhoeger

@pragnagopa pragnagopa added this to the Triaged milestone Jun 4, 2019
@pragnagopa pragnagopa self-assigned this Jun 4, 2019
@pragnagopa
Copy link
Member Author

This will also unblock placeholders when using placeholder pools

@pragnagopa
Copy link
Member Author

cc @mhoeger

@pragnagopa pragnagopa removed their assignment Jul 16, 2019
@mhoeger mhoeger self-assigned this Aug 21, 2019
@fabiocav fabiocav removed this from the Triaged milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants