Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out headers with empty values for Node.js #5975

Closed
mhoeger opened this issue May 4, 2020 · 0 comments · Fixed by #6100
Closed

Filter out headers with empty values for Node.js #5975

mhoeger opened this issue May 4, 2020 · 0 comments · Fixed by #6100
Assignees
Labels

Comments

@mhoeger
Copy link
Contributor

mhoeger commented May 4, 2020

Note - we probably don't want to filter out for everything because this behavior is only buggy for Node.js. Correct approach is through capabilities and either explicitly opting out of those or introducing a new headers property that is typed correctly.

This issue exists because of the way we implemented headers in our protobuf schema (as a map<string, string>) and the "map" type doesn't accept empty values for runtimes like node. Causes buffer overrun and corrupts other parts of the message :(

Azure/azure-functions-nodejs-worker#142 and Azure/azure-functions-language-worker-protobuf#21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.