Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'worker.config.json' configuration hardcoded for Windows #421

Closed
shaunthomas999 opened this issue Feb 27, 2021 · 4 comments · Fixed by #586 · May be fixed by #516
Closed

'worker.config.json' configuration hardcoded for Windows #421

shaunthomas999 opened this issue Feb 27, 2021 · 4 comments · Fixed by #586 · May be fixed by #516
Labels
triaged

Comments

@shaunthomas999
Copy link

Current worker.config.json has windows specific environment variable reference because of which azure-functions-java-worker won't work in macOS (also in linux)

E.g., JAVA_HOME - referenced as %JAVA_HOME%

Repro steps

Failed to start Worker Channel. Process fileName: %JAVA_HOME%/bin/java

Known workarounds
@amamounelsayed
Copy link
Contributor

Thank you so much for reporting this issue.

@shaunthomas999
Copy link
Author

Actually, change %JAVA_HOME% to $JAVA_HOME didn't work for me eventually. I had to give full path to the java executable to make it work.

@shaunthomas999
Copy link
Author

shaunthomas999 commented Mar 31, 2021 •
edited
Loading

@amamounelsayed - Any idea when this issue will be fixed?

@brunoborges
Copy link
Member

Can we change the title of this issue to worker.config.json configuration hardcoded for Windows?

Because this is preventing the worker from running on Linux and WSL (Windows Subsystem for Linux) besides macOS.

brunoborges added a commit to brunoborges/azure-functions-java-worker that referenced this issue Jan 18, 2022
@brunoborges
Remove hardcoded Windows env var for JAVA_HOME
5171cb9 
This fixes Azure#421
@brunoborges brunoborges mentioned this issue Jan 18, 2022
Open
7 tasks
@amamounelsayed amamounelsayed changed the title worker.config.json configuration not working in macOS 'worker.config.json' configuration hardcoded for Windows Jan 18, 2022
@kaibocai kaibocai linked a pull request Jun 24, 2022 that will close this issue
Update worker.config.json to include profiles that enable and disable app insights #586
Merged
7 tasks
@kaibocai kaibocai mentioned this issue Jun 24, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
No milestone
3 participants
@brunoborges @shaunthomas999 @amamounelsayed