Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long dependency #306

Open
ejizba opened this issue Oct 9, 2024 · 0 comments
Open

Remove long dependency #306

ejizba opened this issue Oct 9, 2024 · 0 comments

Comments

@ejizba
Copy link
Contributor

ejizba commented Oct 9, 2024

Background: We mainly use the long package because it's a dependency of our rpc packages. I'm honestly not sure how or when the long classes/types are used by customers. My hope is that they're not actually used and if we just remove them we'd be okay. Compared to undici, long is only one file and so probably has a much smaller impact on cold start.

Breaking change: Like I said, I hope long isn't used in practice. Rather than trying to verify if/when customers use it, I figure it's easier for us to just remove it in a new v5 version as a breaking change. I don't even think we need to have any replacement functionality, other than being ready to add long back if too many customers complain.

Branch to remove: ej/removeLong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant