Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move templates to official v2 schema #308

Open
ejizba opened this issue Oct 16, 2024 · 0 comments
Open

Move templates to official v2 schema #308

ejizba opened this issue Oct 16, 2024 · 0 comments

Comments

@ejizba
Copy link
Contributor

ejizba commented Oct 16, 2024

Templates for the v4 model are currently hard-coded in tooling and also don't match the official v2 schema. They are using a schema I'll call v1.1, which was a temporary workaround to get these working before the v2 schema was finalized. The v1.1 schema was something I came up with and the goal was to minimize the changes from v1 while still fully supporting the new model templates at parity with the old model. By comparison, the v2 schema is way different than the v1 schema so moving to that schema (once it was finalized) was more complicated.

v1.1 schema

Hard-coded location of v1.1 schema templates:

Here is the custom logic to support the v1.1 schema (just as an fyi):

v2 schema

I worked on updating templates to the v2 schema, but we abandoned the effort after we decided we weren't going to support the portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant