Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all the message types in StreamingMessage #184

Closed
pragnagopa opened this issue Mar 2, 2019 · 2 comments · Fixed by #197
Closed

Implement all the message types in StreamingMessage #184

pragnagopa opened this issue Mar 2, 2019 · 2 comments · Fixed by #197
Assignees
@mhoeger
Labels
P1
Milestone
Functions Sprint 48

Comments

@pragnagopa
Copy link
Member

Functions host will start sending various messages defined under StreamingMessage: https://github.com/Azure/azure-functions-language-worker-protobuf/blob/dev/src/proto/FunctionRpc.proto#L20

To avoid breaking language worker, please implement all of them otherwise grpc will start throwing errors.
Note: only dummy implementations needed for now to avoid breaking changes
@pragnagopa pragnagopa added this to the Functions Sprint 44 milestone Mar 2, 2019
@jeffhollan
Copy link

similar comment

@jeffhollan jeffhollan modified the milestones: Functions Sprint 44, Triaged Mar 4, 2019
@pragnagopa pragnagopa added the P1 label Mar 4, 2019
@pragnagopa pragnagopa modified the milestones: Triaged, Functions Sprint 45 Mar 4, 2019
@pragnagopa
Copy link
Member Author

This is a prerequisite for placeholders and Azure/azure-functions-host#3543
I have opened tracking items for all the workers as this is a breaking change for the language workers

@mhoeger mhoeger mentioned this issue Apr 3, 2019
Merged
@fabiocav fabiocav removed the blocked label Apr 17, 2019
@mhoeger mhoeger mentioned this issue May 29, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhoeger mhoeger

Labels
P1
Projects
None yet
Milestone
Functions Sprint 48
Development

Successfully merging a pull request may close this issue.

Implement worker messages mhoeger/azure-functions-nodejs-worker
5 participants
@brettsam @pragnagopa @fabiocav @jeffhollan @mhoeger