Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "sys" from trigger data from host => language worker #317

Closed
mhoeger opened this issue Jul 7, 2020 · 3 comments
Closed

Remove "sys" from trigger data from host => language worker #317

mhoeger opened this issue Jul 7, 2020 · 3 comments
Assignees

Comments

@mhoeger
Copy link
Contributor

mhoeger commented Jul 7, 2020

Currently, we pass data like "sys" (and for HTTP, "query" and "headers". However values in "sys" in particular are not RPC-friendly and we should avoid passing those values if we can.

Node.js worker is the only worker that we manage that exposes these values to end-users.

@ghost ghost assigned madelinegordon Jul 7, 2020
@pragnagopa pragnagopa transferred this issue from Azure/azure-functions-host Jul 7, 2020
@pragnagopa pragnagopa added this to the Triaged milestone Jul 7, 2020
@pragnagopa
Copy link
Member

Transferred issue here. If possible please assign it to next sprint. Thanks!

@mathewc
Copy link
Member

mathewc commented Jul 22, 2020

Yes, for this change, we should add query/headers from the request body sent. Then we'll be able to reapply my http extension changes to omit these from the payload. As you mention, we'll also remove the "sys" node.

@mhoeger
Copy link
Contributor Author

mhoeger commented Aug 4, 2020

hey @mathewc - sorry I missed your note there! :(
Here's the issue tracking the change to our protobuf contract: Azure/azure-functions-language-worker-protobuf#49
and this is tracking the node worker changes:
#324

These both will let us remove "query" and "headers" from trigger metadata that gets passed over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants