fixed tests

Author: hallvictoria

azure-functions-extension-base/azure/functions/extension/base/utils.py

@@ -250,11 +250,6 @@ def get_raw_bindings(indexed_function, input_types):
     bindings_logs = {}
     for b in indexed_function._bindings:
         dict_repr, logs = Binding.get_dict_repr(b, input_types)
-        binding_dict_repr.append(json.dumps(dict_repr,  cls=StringifyEnumJsonEncoder))
+        binding_dict_repr.append(json.dumps(dict_repr, cls=StringifyEnumJsonEncoder))
         bindings_logs.update(logs)
     return binding_dict_repr, bindings_logs
-
-    # return [
-    #     json.dumps(Binding.get_dict_repr(b, input_types), cls=StringifyEnumJsonEncoder)
-    #     for b in indexed_function._bindings
-    # ]

azure-functions-extension-base/tests/test_meta.py

@@ -146,7 +146,7 @@ class MockIndexedFunction:
             _bindings = {}
             _trigger = None
 
-        self.assertEqual(registry.get_raw_bindings(MockIndexedFunction, []), [])
+        self.assertEqual(registry.get_raw_bindings(MockIndexedFunction, []), ([], {}))
 
         self.assertFalse(registry.check_supported_type(None))
         self.assertFalse(registry.check_supported_type("hello"))

azure-functions-extension-base/tests/test_utils.py

@@ -56,8 +56,9 @@ def test_get_dict_repr_sdk(self):
         # Create test indexed_function
         mock_indexed_functions = MockFunction(bindings=[mock_blob])
 
-        dict_repr = utils.get_raw_bindings(mock_indexed_functions,
-                                                 mock_input_types)
+        dict_repr, logs = utils.get_raw_bindings(
+            mock_indexed_functions, mock_input_types
+        )
         self.assertEqual(
             dict_repr,
             [
@@ -68,6 +69,8 @@ def test_get_dict_repr_sdk(self):
             ],
         )
 
+        self.assertEqual(logs, {"client": (sdkType.SdkType, "True")})
+
     def test_get_dict_repr_non_sdk(self):
         # Create mock blob
         meta._ConverterMeta._bindings = {"blob"}
@@ -88,7 +91,9 @@ def test_get_dict_repr_non_sdk(self):
         # Create test indexed_function
         mock_indexed_functions = MockFunction(bindings=[mock_blob])
 
-        dict_repr = utils.get_raw_bindings(mock_indexed_functions, mock_input_types)
+        dict_repr, logs = utils.get_raw_bindings(
+            mock_indexed_functions, mock_input_types
+        )
         self.assertEqual(
             dict_repr,
             [
@@ -98,6 +103,7 @@ def test_get_dict_repr_non_sdk(self):
                 '{"SupportsDeferredBinding": false}}'
             ],
         )
+        self.assertEqual(logs, {"blob": (bytes, "False")})
 
     def test_get_dict_repr_binding_name_none(self):
         # Create mock blob
@@ -126,14 +132,19 @@ def test_get_dict_repr_binding_name_none(self):
         # Create test indexed_function
         mock_indexed_functions = MockFunction(bindings=[mock_blob, mock_http])
 
-        dict_repr = utils.get_raw_bindings(mock_indexed_functions, mock_input_types)
+        dict_repr, logs = utils.get_raw_bindings(
+            mock_indexed_functions, mock_input_types
+        )
         self.assertEqual(
             dict_repr,
-            ['{"direction": "IN", "dataType": null, "type": "blob", '
-             '"properties": {"SupportsDeferredBinding": false}}',
-             '{"direction": "OUT", "dataType": null, "type": "httpResponse", '
-             '"properties": {"SupportsDeferredBinding": false}}'],
+            [
+                '{"direction": "IN", "dataType": null, "type": "blob", '
+                '"properties": {"SupportsDeferredBinding": false}}',
+                '{"direction": "OUT", "dataType": null, "type": "httpResponse", '
+                '"properties": {"SupportsDeferredBinding": false}}',
+            ],
         )
+        self.assertEqual(logs, {"$return": (None, "False"), "blob": (bytes, "False")})
 
     def test_get_dict_repr_init_params(self):
         # Create mock blob
@@ -158,7 +169,9 @@ def test_get_dict_repr_init_params(self):
         # Create test indexed_function
         mock_indexed_functions = MockFunction(bindings=[mock_blob])
 
-        dict_repr = utils.get_raw_bindings(mock_indexed_functions, mock_input_types)
+        dict_repr, logs = utils.get_raw_bindings(
+            mock_indexed_functions, mock_input_types
+        )
         self.assertEqual(
             dict_repr,
             [
@@ -168,6 +181,8 @@ def test_get_dict_repr_init_params(self):
             ],
         )
 
+        self.assertEqual(logs, {"client": (sdkType.SdkType, "True")})
+
     def test_binding_data_type(self):
         mock_blob = utils.Binding(
             name="blob",