Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version comparison logic to be stable across releases #1545

Open
mattchenderson opened this issue Jul 19, 2024 · 0 comments
Open

Update version comparison logic to be stable across releases #1545

mattchenderson opened this issue Jul 19, 2024 · 0 comments
Labels
.NET Pull requests that update .net code

Comments

@mattchenderson
Copy link
Contributor

This code should not need to be updated as new versions become available:

"Framework": {
"type": "bind",
"binding": "msbuild:TargetFramework",
"defaultValue": "net6.0"
},
"NetFramework": {
"type": "computed",
"datatype": "bool",
"value": "(Framework == \"net48\")"
},
"NetCore": {
"type": "computed",
"datatype": "bool",
"value": "(Framework == \"net6.0\" || Framework == \"net7.0\" || Framework == \"net8.0\" || Framework == \"net9.0\")"
},

This should instead parse the version and perform a comparison against the minimum.

@mattchenderson mattchenderson added the .NET Pull requests that update .net code label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Pull requests that update .net code
Projects
None yet
Development

No branches or pull requests

1 participant