Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwinCollection Max Depth Issue #699

Closed
bouff opened this issue Jan 30, 2020 · 5 comments
Closed

TwinCollection Max Depth Issue #699

bouff opened this issue Jan 30, 2020 · 5 comments
Assignees
Labels
bug fix checked in Fix checked into main or preview, but not yet released.

Comments

@bouff
Copy link

bouff commented Jan 30, 2020

  • OS and version used:
    macOS 10.15.2
  • Java runtime used:
    JDK 1.8
  • SDK version used:
    iot-service-client version 1.19.0

Description of the issue:

As per the IoT Hub documentation, the depth limitation for desired properties, reported properties, and tag is 10.

https://docs.microsoft.com/en-us/azure/iot-hub/iot-hub-devguide-device-twins#tags-and-properties-format

The value is currently hard-coded at 6.

https://github.com/Azure/azure-iot-sdk-java/blob/master/deps/src/main/java/com/microsoft/azure/sdk/iot/deps/twin/TwinCollection.java

This is essentially a reincarnation of the following issue:
#338

Would it be possible to either update the value (or remove that validation, as discussed in the previous issue)?

Code sample exhibiting the issue:

Console log of the issue:

Need Support?

  • Have a feature request for SDKs? Please post it on User Voice to help us prioritize.
  • Have a technical question? Ask on Stack Overflow with tag “azure-iot-hub”
  • Need Support? Every customer with an active Azure subscription has access to support with guaranteed response time. Consider submitting a ticket and get assistance from Microsoft support team
  • Found a bug? Please help us fix it by thoroughly documenting it and filing an issue on GitHub (C, Java, .NET, Node.js, Python).
@timtay-microsoft
Copy link
Member

timtay-microsoft commented Jan 30, 2020

Since the max depth appears to have changed from 5 to 10 from the service's perspective, it's probably a good idea for the SDK to just not care about the twin depth. We should definitely remove the code that validates that twin fits a certain depth

@timtay-microsoft timtay-microsoft self-assigned this Feb 10, 2020
@timtay-microsoft timtay-microsoft added the fix checked in Fix checked into main or preview, but not yet released. label Feb 10, 2020
@eanavalentin
Copy link

Hi, is there an expected timeline for a new release which will include this fix?
We're also encountering this problem in production with an application which just stops execution and hangs on client connection to azure when we have reported properties with a depth of 7.

@timtay-microsoft
Copy link
Member

I'm trying to get a new version of the SDK released with this fix by the end of this week. I'll update this thread once it is released

@timtay-microsoft
Copy link
Member

As of this release, all SDK twin depth validation is removed, so I'm closing this issue

@az-iot-builder-01
Copy link
Collaborator

@bouff, @morphvale, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix checked in Fix checked into main or preview, but not yet released.
Projects
None yet
Development

No branches or pull requests

4 participants