Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide CancellationToken to cancel PSH cmdlet #14867

Open
blueww opened this issue Apr 29, 2021 · 1 comment
Open

Provide CancellationToken to cancel PSH cmdlet #14867

blueww opened this issue Apr 29, 2021 · 1 comment
Assignees
@msJinLei
Labels
Engineering
Milestone
Backlog

Comments

@blueww
Copy link
Member

blueww commented Apr 29, 2021

Description

Could we provide a CancellationToken in PSH cmdlet base class, so each cmdlets can use the CancellationToken to cancel the request send in the cmdlets when user press Ctrl+C.

Cost

TBD
@blueww blueww added Engineering needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Apr 29, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 29, 2021
@dingmeng-xue dingmeng-xue added this to the Backlog milestone May 6, 2021
@dingmeng-xue
Copy link
Member

We need to make RetryHandler and AfterRetryHandler to honor CancellationToken. In addition, abstract cmdlet needs to listen pressing Ctrl+C event.

The solution should cover management plane and data plane.

@jiasli jiasli mentioned this issue Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msJinLei msJinLei

Labels
Engineering
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@blueww @msJinLei @dingmeng-xue