Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cplat add az vhd improve #17999

Merged
merged 33 commits into from
Jun 17, 2022
Merged

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Apr 27, 2022

Description

This iteration of improvment

  • Resolve VHD file path and only use that
  • refactor validateVHD to getVDSLength
  • covertVHD() and resizeVHD() functions return new filepaths
  • if upload fails, clean up resource and return terminating error
  • check OS at the beginning of resizeVHD() and convertVHD()
  • add warnings at the beginning of resizeVHD() and convertVHD()

Future iteration

  • option to skip MD5 hasing
  • resize on the fly
  • convert VHDX to VHD on the fly

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@grizzlytheodore grizzlytheodore marked this pull request as ready for review May 27, 2022 22:08
@grizzlytheodore
Copy link
Member Author

@VeryEarly @msJinLei could someone be assigned approve/merge please !

@VeryEarly VeryEarly self-assigned this Jun 15, 2022
@grizzlytheodore
Copy link
Member Author

@VeryEarly updated. most of the changes are behind the scenes change that do not change any customer experience, but i added the the changes that do impact customers

@VeryEarly VeryEarly closed this Jun 17, 2022
@VeryEarly VeryEarly reopened this Jun 17, 2022
@VeryEarly
Copy link
Collaborator

closed the pr in accident, will merge after CI passed

VeryEarly
VeryEarly previously approved these changes Jun 17, 2022
@VeryEarly VeryEarly merged commit f3123d7 into main Jun 17, 2022
@grizzlytheodore grizzlytheodore deleted the feature/cplat-Add-AzVhdImprove branch September 15, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants