Merge branch 'master_upstream' into narinem-dataplane-swagger

Author: NarineM

.azure-pipelines-preproduction/package-lock.json

@@ -11,7 +11,7 @@
   "license": "MIT",
   "devDependencies": {
     "@azure/avocado": "^0.6.2",
-    "@azure/rest-api-specs-scripts": "^0.5.7",
+    "@azure/rest-api-specs-scripts": "^0.6.8",
     "@ts-common/commonmark-to-markdown": "^1.2.0",
     "@ts-common/fs": "0.2.0",
     "@ts-common/iterator": "^0.3.6",

.azure-pipelines-preproduction/package.json

@@ -9,3 +9,4 @@ jobs:
       verbose: false
   - script: './node_modules/.bin/avocado'
     displayName: 'Avocado'
+    condition: ne(variables['Build.SourceBranch'], 'refs/heads/master')

.azure-pipelines/Avocado.yml

@@ -7,14 +7,15 @@ trigger:
 pr:
   autoCancel: false
 
+variables:
+  IMAGE: azopenapi.azurecr.io/openapi/sdk-automation:prod
+  REGISTRY_ENDPOINT: azopenapi-registry
+
 jobs:
 - job: "SDKAutomation"
   displayName: SDK
   pool:
     vmImage: 'Ubuntu 18.04'
-  container:
-    image: azopenapi.azurecr.io/openapi/sdk-automation:prod
-    endpoint: azopenapi-registry
   timeoutInMinutes: 180
 
   variables:
@@ -32,27 +33,45 @@ jobs:
         SDK_REPO_NAME: azure-sdk-for-js
       Python:
         SDK_REPO_NAME: azure-sdk-for-python
+      Cliextension:
+        SDK_REPO_NAME: azure-cli-extensions
       Go:
         SDK_REPO_NAME: azure-sdk-for-go
   steps:
   - checkout: none
-  - script: printenv
-    displayName: Display ENV
-  - script: git config --global user.email "sdkautomation@microsoft.com" && git config --global user.name "SDK Automation"
-    displayName: Configure Git
   - script: |
       curl \
         -s https://api.github.com/repos/$(Build.Repository.Name)/commits/$(Build.SourceVersion)/pulls \
         -H "Accept: application/vnd.github.groot-preview+json" \
       | python3 -c "import sys,json; a=json.load(sys.stdin); print(f'##vso[task.setvariable variable=PR_NUMBER]{a[0][\"number\"]}' if len(a)>0 and a[0][\"base\"][\"ref\"]=='master' else '##vso[task.logissue type=error]Last commit $(Build.SourceVersion) doesnot have a related PR')"
     displayName: Get PR_NUMBER
     condition: in(variables['Build.Reason'], 'IndividualCI', 'Manual')
-  - script: sudo chown `id -ng`:`id -ng` . && npm start
+  - task: Docker@2
+    displayName: Login into ACR
+    inputs:
+      command: login
+      containerRegistry: $(REGISTRY_ENDPOINT)
+  - script: |
+      docker pull $IMAGE
+      docker tag $IMAGE sdk-automation:latest
+    displayName: Pull SDK Automation Image
+  - script: |
+      docker run \
+        -e BLOB_STORAGE_NAME \
+        -e BLOB_STORAGE_KEY \
+        -e GITHUB_COMMENT_AUTHOR_NAME \
+        -e GITHUBAPP_ID \
+        -e GITHUBAPP_PRIVATE_KEY \
+        -e NODE_OPTIONS \
+        -e BLOB_STORAGE_PREFIX \
+        -e SPEC_REPO \
+        -e PR_NUMBER \
+        -e SDK_REPO_NAME \
+        sdk-automation:latest npm start
     env:
       BLOB_STORAGE_NAME: $(blob-storage-name)
       BLOB_STORAGE_KEY: $(blob-storage-key)
       GITHUB_COMMENT_AUTHOR_NAME: $(github-comment-author-name)
       GITHUBAPP_ID: $(githubapp-id)
       GITHUBAPP_PRIVATE_KEY: $(githubapp-private-key)
     displayName: SDK Automation
-    workingDirectory: /z

.azure-pipelines/SDKAutomation.yml

@@ -12,6 +12,9 @@ jobs:
       python:
         AZURE_SDK_REPO: azure-sdk-for-python
         AZURE_SDK_PARAMS: ''
+      cliextension:
+        AZURE_SDK_REPO: azure-cli-extensions
+        AZURE_SDK_PARAMS: ''
       go:
         AZURE_SDK_REPO: azure-sdk-for-go
         AZURE_SDK_PARAMS: '-o latest'

.azure-pipelines/SwaggerToSDK.yml

@@ -0,0 +1,139 @@
+---
+- rule:
+    # data-plane PR
+    paths: 
+      - "specification/**/data-plane/**"
+    reviewers:
+      - anuchandy
+      - jhendrixMSFT
+      - lmazuel
+      - tjprescott
+
+- rule:
+    paths: 
+      - "specification/network/**"
+    reviewers:
+      - lirenhe
+      - zikalino
+      - MyronFanQiu
+
+- rule:
+    paths: 
+      - "specification/@(applicationinsights|operationalinsights)/**"
+    reviewers:
+      - MyronFanQiu
+
+- rule:
+    paths: "specification/compute/**"
+    reviewers:
+      - ArcturusZhang
+      - fengzhou-msft
+      - yungezz
+
+- rule:
+    paths: 
+      - "specification/machinelearningservices/**"
+    reviewers:
+      - ArcturusZhang 
+
+- rule:
+    paths: 
+      - "specification/authorization/**"
+    reviewers:
+      - qianwens
+      - yungezz
+
+- rule:
+    paths:
+      - "specification/datafactory/**"
+    reviewers:
+      - qianwens
+
+- rule:
+    paths:
+      - "specification/monitor/**"
+    reviewers:
+      - weidongxu-microsoft 
+      - MyronFanQiu
+
+- rule:
+    paths:
+      - "specification/storage/**"
+    reviewers:
+      - qianwens
+      - Juliehzl
+
+- rule:
+    paths: "specification/mediaservices/**"
+    reviewers:
+      - allenjzhang
+
+- rule:
+    paths: 
+      - "specification/@(keyvault|notificationhubs)/**"
+      - "specification/@(databricks|containerregistry)/**"
+    reviewers:
+      - fengzhou-msft
+
+- rule:
+    paths:
+      - "specification/@(containerservice|containerinstance)/**"
+    reviewers:
+      - NullMDR
+      - fengzhou-msft 
+      - yungezz
+
+- rule:
+    paths:
+      - "specification/portal/**"
+    reviewers:
+      - NullMDR
+
+- rule:
+    paths:
+      - "specification/web/**"
+    reviewers:
+      - weidongxu-microsoft
+
+- rule:
+    paths: 
+      - "documentation/**"
+    reviewers:
+      - josefree
+      - akning-ms
+
+- rule:
+    paths: 
+      - "**/package.json"
+      - ".github/**"
+      - "**/azure-pipelines.yml"
+      - ".azure-pipelines/**"
+      - ".azure-pipelines-preproduction/**"
+    reviewers:
+      - akning-ms
+      - ruowan
+      - NullMDR
+
+- rule:
+    # manager-plane PR
+    paths: 
+      - "**"
+    reviewers:
+      - yungezz
+      - zikalino
+      - yaohaizh
+      - erich-wang
+      - NullMDR
+      - raych1
+      - lirenhe
+      - weidongxu-microsoft
+      - ArcturusZhang
+      - xccc-msft
+      - ChenTanyi
+      - fengzhou-msft
+      - njuCZ
+      - akning-ms
+      - markcowl
+      - leni-msft
+      - qianwens
+      - allenjzhang

.github/assignment.yml

@@ -34,7 +34,7 @@
 /specification/insights/ @gucalder
 /specification/intune/ @vrmurthy01
 /specification/iothub/ @rkmanda
-/specification/keyvault/ @schaabs
+/specification/keyvault/ @schaabs @heaths
 /specification/logic/ @pankajsn @tonytang-microsoft-com
 /specification/machinelearning/ @nonstatic2014
 /specification/machinelearningcompute/ @shutchings

CODEOWNERS

@@ -220,6 +220,18 @@
                 "Regenerte"
             ]
         },
+        {
+            "filename": "**/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.1/storage.json",
+            "words": [
+                "Regenerte"
+            ]
+        },
+        {
+            "filename": "**/specification/keyvault/data-plane/Microsoft.KeyVault/preview/7.2/storage.json",
+            "words": [
+                "Regenerte"
+            ]
+        },
         {
             "filename": "**/specification/adhybridhealthservice/resource-manager/Microsoft.ADHybridHealthService/stable/2014-01-01/ADHybridHealthService.json",
             "words": [

cSpell.json

@@ -32,6 +32,7 @@ adminmanagement
 ADTO
 adultscore
 affinitized
+agentpool
 aggregatedcost
 AHUB
 AIAPI
@@ -115,6 +116,8 @@ australiasoutheast
 authenticatable
 Authenticode
 authorizationrules
+authprovider
+authproviders
 authsettings
 authsid
 autobackup
@@ -175,8 +178,10 @@ bacpac
 badpassword
 Baidu
 bangla
+Bahasa
 baremetal
 BATCHAI
+batchmanaged
 BAYESIANOPTIMIZATION
 BCDR
 BCWG
@@ -212,6 +217,7 @@ BMCI
 BMCIP
 BMSPO
 BMSRP
+Bokmål
 Bokmaal
 Bootstrappers
 bot's
@@ -485,6 +491,7 @@ entrypoint
 environmentsettings
 errordetail
 errored
+ErrorMesssage
 ErrorSchema
 Español
 estaba
@@ -553,6 +560,7 @@ fsaction
 Fulfilment
 Fulltext
 fullyqualified
+functionappsettings
 galician
 galleryimages
 Garda
@@ -965,6 +973,7 @@ nonpaged
 nonreadable
 nonstarted
 Nonsupported
+nopublicipaddresses
 northcentralus
 northeurope
 nostore
@@ -1030,6 +1039,7 @@ pageable
 Parallelise
 paramref
 PARAVIRTUAL
+partnertopic
 Passthrough
 patternanyentities
 patternrule
@@ -1132,6 +1142,7 @@ querystring
 querytriggers
 Queretaro
 queueservices
+QueueStatus
 quickbooks
 quicktest
 quniform
@@ -1213,6 +1224,7 @@ reprovisions
 Reregister
 Rescan
 reservationorders
+resetapikey
 resetvpnclientsharedkey
 Resolvability
 resourcegraph
@@ -1295,6 +1307,7 @@ SECP
 secureobject
 securestring
 securityinsight
+seealso
 serialconsole
 servererror
 serverfarm
@@ -1394,6 +1407,7 @@ starttask
 starttaskfailed
 starttime
 stateful
+staticsite
 statusdir
 stderror
 stopresize
@@ -1476,6 +1490,7 @@ Taxii
 templated
 templatelink
 templeton
+temporarydisk
 tensorflow
 teradata
 terminatejob
@@ -1588,6 +1603,7 @@ userflows
 userid
 userpreference
 usersetting
+usermanaged
 USQL
 VAIDK
 varbinary
@@ -1716,3 +1732,8 @@ getactivesessions
 disconnectactivesessions
 bsls
 sessionids
+Dsms
+cloudManifestFiles
+highestcriticalimpact
+apiserver
+kubeadmin

custom-words.txt

@@ -4,7 +4,9 @@ Here are guides to fix some of the CI failure.
 
 ## Spell check
 
-Please add your words to `./custom-words.txt` if you think you have the correct spell
+Please add your words to `./custom-words.txt` if you think you have the correct spell.
+
+If your problem is some existing error name that is not a word and need to supress the error in that file (and don't want to add to custom-words.txt), you can add it to `./cSpell.txt`.
 
 ## Prettier check