Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Weird use for status code 429 #1124

Closed
mcardosos opened this issue Apr 14, 2017 · 10 comments
Closed

[Network] Weird use for status code 429 #1124

mcardosos opened this issue Apr 14, 2017 · 10 comments
Labels
Network P1 Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@mcardosos
Copy link
Contributor

mcardosos commented Apr 14, 2017

Related to Azure/azure-sdk-for-go#588
When creating or updating subnets, it can happen that the API return status code 429 and a message clarifying that this is a retryable error, (unlike the normal use of 429 which means to many requests).
My guess is that doing the very same request later, it will succeed.
Still, it would be weird to include status code 429 as a valid code to retry for in the SDKs. Is it possible to include this status code with this message in the swagger to indicate it is safe to continue retrying?
@amarzavery @whiskeyjay @marstr @jhendrixMSFT

@mcardosos
Copy link
Contributor Author

@jobatzil what do you think?

@jhendrixMSFT
Copy link
Member

Any update here? This resulted in a real customer issue in the Go SDK . We were able to prescribe a workaround however we'd like to understand if this is a best practice.

@mcardosos
Copy link
Contributor Author

poke @amarzavery

@kirthik
Copy link
Contributor

kirthik commented May 10, 2017

@DeepakRajendranMsft - Could you please take a look at this issue?

@kirthik kirthik added the P1 label May 16, 2017
@tombuildsstuff
Copy link
Contributor

👋 @DeepakRajendranMsft @kirthik is there any update/expected timeline to fix this? :)

@liumichelle
Copy link

The fix for this in progress - TBD ETA

@DeepakRajendranMsft
Copy link
Contributor

We are still working on this, sorry. we are evaluating that if we have 429 as a retryable error, it may break clients out there that have a special treatment for 429 since they might expect an exception from SDKs generated by us

@jhendrixMSFT
Copy link
Member

Even with a Retry-After header in the response?

@mcardosos
Copy link
Contributor Author

Little documentation on 429 usage. With this as context, I think 429 usage is not something that has to do with this repository. 429 needs a different treatment than other status codes when we are talking about retry strategies. Retry strategies live on each language SDK client runtime. This has been fixed on the go SDK runtime here.

@mcardosos
Copy link
Contributor Author

Fixed for go here Azure/go-autorest#155

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Network P1 Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

7 participants