-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network] Weird use for status code 429 #1124
Comments
@jobatzil what do you think? |
Any update here? This resulted in a real customer issue in the Go SDK . We were able to prescribe a workaround however we'd like to understand if this is a best practice. |
poke @amarzavery |
@DeepakRajendranMsft - Could you please take a look at this issue? |
👋 @DeepakRajendranMsft @kirthik is there any update/expected timeline to fix this? :) |
The fix for this in progress - TBD ETA |
We are still working on this, sorry. we are evaluating that if we have 429 as a retryable error, it may break clients out there that have a special treatment for 429 since they might expect an exception from SDKs generated by us |
Even with a Retry-After header in the response? |
Little documentation on 429 usage. With this as context, I think 429 usage is not something that has to do with this repository. 429 needs a different treatment than other status codes when we are talking about retry strategies. Retry strategies live on each language SDK client runtime. This has been fixed on the go SDK runtime here. |
Fixed for go here Azure/go-autorest#155 |
Related to Azure/azure-sdk-for-go#588
When creating or updating subnets, it can happen that the API return status code 429 and a message clarifying that this is a retryable error, (unlike the normal use of 429 which means to many requests).
My guess is that doing the very same request later, it will succeed.
Still, it would be weird to include status code 429 as a valid code to retry for in the SDKs. Is it possible to include this status code with this message in the swagger to indicate it is safe to continue retrying?
@amarzavery @whiskeyjay @marstr @jhendrixMSFT
The text was updated successfully, but these errors were encountered: