Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operationalinsights/2019-08-01-preview paginated model without nextLink defined #11420

Closed
ArcturusZhang opened this issue Oct 28, 2020 · 5 comments
Closed

Operationalinsights/2019-08-01-preview paginated model without nextLink defined #11420

ArcturusZhang opened this issue Oct 28, 2020 · 5 comments
Labels
Monitor - Operational Insights Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@ArcturusZhang
Copy link
Member

In operationalinsights/2019-08-01-preview, the operation DataExport_ListByWorkspace is defined a paginated operation (here), but the corresponding model returned does not specify a field of nextLink.

This issue blocks the generated SDK.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 28, 2020
@ArcturusZhang ArcturusZhang added Monitor - Operational Insights Service Attention Workflow: This issue is responsible by Azure service team. labels Oct 28, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 28, 2020
@ArcturusZhang ArcturusZhang mentioned this issue Oct 28, 2020
Merged
5 tasks
@ArcturusZhang ArcturusZhang changed the title Operationalinsights/2019-08-01-preview pagable model without nextLink defined Operationalinsights/2019-08-01-preview paginated model without nextLink defined Oct 28, 2020
@shemers
Copy link

shemers commented Nov 5, 2020

@ArcturusZhang is this still an issue?

@ArcturusZhang
Copy link
Member Author

Hi @shemers yes this is only resolved when the nextlink was added to this model

@ArcturusZhang
Copy link
Member Author

Hi any updates?

This was referenced Dec 1, 2020
Merged
Merged
@ghost ghost added the no-recent-activity label Dec 22, 2020
@Azure Azure deleted a comment Dec 23, 2020
@ghost ghost removed the no-recent-activity label Dec 23, 2020
@yossi-y
Copy link

yossi-y commented Mar 1, 2021

We have fixed this in the new version (2020-08-01) and working to publish it.
We recommend that you move to the newer version to get this change affected.

@ArcturusZhang
Copy link
Member Author

We have fixed this in the new version (2020-08-01) and working to publish it.
We recommend that you move to the newer version to get this change affected.

It is fine, but please notice that the issue in 2019-08-01-preview is still unresolved and no SDK will release for this api-version. All release request on this api-version for go sdk will be rejected.

still, fixing it is as simple as adding a new readonly property in the swagger which certainly will not trigger the breaking change alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Monitor - Operational Insights Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PhoenixHe-NV @ArcturusZhang @yossi-y @shemers