Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate Operations_List in applicationinsights package-2021-11-01 #17215

Closed
cataggar opened this issue Jan 4, 2022 · 2 comments
Closed

duplicate Operations_List in applicationinsights package-2021-11-01 #17215

cataggar opened this issue Jan 4, 2022 · 2 comments
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@cataggar
Copy link
Member

cataggar commented Jan 4, 2022

applicationinsights added package-2021-11-01 in commit c03e6d6:

### Tag: package-2021-11-01
These settings apply only when `--tag=package-2021-11-01` is specified on the command line.
``` yaml $(tag) == 'package-2021-11-01'
input-file:
- Microsoft.Insights/stable/2015-05-01/aiOperations_API.json
- Microsoft.Insights/stable/2015-05-01/componentAnnotations_API.json
- Microsoft.Insights/stable/2015-05-01/componentApiKeys_API.json
- Microsoft.Insights/stable/2015-05-01/componentContinuousExport_API.json
- Microsoft.Insights/stable/2015-05-01/componentFeaturesAndPricing_API.json
- Microsoft.Insights/stable/2015-05-01/componentProactiveDetection_API.json
- Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json
- Microsoft.Insights/stable/2015-05-01/favorites_API.json
- Microsoft.Insights/stable/2015-05-01/webTestLocations_API.json
- Microsoft.Insights/stable/2015-05-01/webTests_API.json
- Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json
- Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json
- Microsoft.Insights/stable/2021-03-08/myworkbooks_API.json
- Microsoft.Insights/stable/2021-08-01/workbooks_API.json
- Microsoft.Insights/preview/2018-05-01-preview/components_API.json
- Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json
- Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json
```

The problem is explained in the Azure SDK for Go workaround:

```yaml $(go) && $(track2)
license-header: MICROSOFT_MIT_NO_VERSION
module-name: sdk/resourcemanager/applicationinsights/armapplicationinsights
module: github.com/Azure/azure-sdk-for-go/$(module-name)
output-folder: $(go-sdk-folder)/$(module-name)
azure-arm: true
directive:
# Duplicate OperationId Operations_List is detected in Microsoft.Insights/stable/2015-05-01/aiOperations_API.json and Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json
from: aiOperations_API.json
where: $.paths
transform: delete $["/providers/Microsoft.Insights/operations"]
```

This does not work for Azure SDK for Rust or third party code generators. There should not be a duplicate operation definition.

directive:
# Duplicate OperationId Operations_List is detected in Microsoft.Insights/stable/2015-05-01/aiOperations_API.json and Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json
  from: aiOperations_API.json
  where: $.paths
  transform: delete $["/providers/Microsoft.Insights/operations"]

A suggested solution would be to copy Microsoft.Insights/stable/2015-05-01/aiOperations_API.json to a new API folder and remove Operations_List.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 4, 2022
@cataggar
Copy link
Member Author

cataggar commented Jan 5, 2022

It was livetoken_API.json that introduced the duplicate. Here is a pull request to remove it #17243.

@cataggar
Copy link
Member Author

cataggar commented Jan 5, 2022

This is just a symptom. The versioning for this service should be reviewed.

@cataggar cataggar closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
1 participant