Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[key vault] vaultUri in resource manager spec must be readonly #9432

Closed
iscai-msft opened this issue May 12, 2020 · 7 comments · Fixed by #11040
Closed

[key vault] vaultUri in resource manager spec must be readonly #9432

iscai-msft opened this issue May 12, 2020 · 7 comments · Fixed by #11040
Assignees
@heaths @RandalliLama @zikalino @jlichwa
Labels
KeyVault Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@iscai-msft
Copy link
Contributor

For context, a client opened an issue here: Azure/azure-sdk-for-python#11333.

The swagger has vaultUri defined as just a string. In order to make it readonly, a line like this needs to be added to its swagger definition

Seeing this for at least API version 2019-09-01.
@iscai-msft iscai-msft mentioned this issue May 12, 2020
Closed
@raych1 raych1 added the Service Attention Workflow: This issue is responsible by Azure service team. label May 13, 2020
@ghost
Copy link

ghost commented May 13, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @RandalliLama, @schaabs, @jlichwa.

@jlichwa
Copy link
Contributor

jlichwa commented Jul 24, 2020

@RandalliLama is it ok to make it readonly?

@jeking3
Copy link

jeking3 commented Sep 30, 2020

Friendly ping. :) Seems to have stalled.

@jlichwa jlichwa mentioned this issue Oct 5, 2020
Merged
10 tasks
@jlichwa jlichwa linked a pull request Oct 5, 2020 that will close this issue
Update keyvault.json #11040
Merged
10 tasks
@jeking3
Copy link

jeking3 commented Oct 13, 2020

Note this issue will not be resolved fully by the linked update; the documentation will be updated however the swagger definition will still be wrong.

@sebansal
Copy link
Contributor

sebansal commented Nov 6, 2020

Hi @jlichwa
I was triaging this list, can you share if it has been resolved and can be closed?
Thanks

@sebansal
Copy link
Contributor

sebansal commented Dec 4, 2020

@jlichwa for review

@jlichwa
Copy link
Contributor

jlichwa commented Dec 4, 2020

@sebansal merge is still in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heaths heaths

@RandalliLama RandalliLama

@zikalino zikalino

@jlichwa jlichwa

Labels
KeyVault Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update keyvault.json Azure/azure-rest-api-specs
8 participants
@heaths @RandalliLama @zikalino @jeking3 @raych1 @iscai-msft @jlichwa @sebansal